Enable building torchvision with ffmpeg regardless of version on Linux #4413
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
@prabhat00155 I don't have context why the version check is removed but I'm sure you have your reasons. Assessing only the PR for what it's supposed to be doing, LGTM.
Accepting to unblock your work.
NicolasHug
reviewed
Sep 15, 2021
Thanks @datumbox! This check was introduced as we used to support ffmpeg 4.2 and there were a lot of issues with 4.3. @bjuncek did some work making torchvision work with ffmpeg 4.3 and now it works fine on Linux, hence I am removing the check. |
NicolasHug
approved these changes
Sep 16, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
…n on Linux (#4413) Summary: * Enable building torchvision with ffmpeg regardless of version on Linux * Skip tests with python 3.9 * Removed PY39_SKIP * Cleaned up a bit Reviewed By: datumbox Differential Revision: D31268050 fbshipit-source-id: b73ea0ab52e16b26a1e7b960833b5e345d545d3d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
torchvision now works fine with latest ffmpeg(4.3) on Linux, hence this check is not needed.