Added paper references to detection models #4383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Sep 8, 2021
There was a problem hiding this comment.
Linter is failing with the error below, but other than that LGTM, thanks @prabhat00155
./torchvision/models/detection/faster_rcnn.py:303:121: E501 line too long (134 > 120 characters)
NicolasHug
reviewed
Sep 8, 2021
Thanks @NicolasHug, yeah ignoring linter on that line by adding # noqa as it's a hyperlink. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 13, 2021
Summary: * Added paper references to detection models * Ignore linter warning * Break long line into two Reviewed By: kazhang Differential Revision: D30898334 fbshipit-source-id: 4de229eb23cf34eb76856fdb57d6451b40e9f8a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion: #3430 (comment)
cc @datumbox