Update weights of classification models to allow proper unpickling #3620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3620 +/- ##
=======================================
Coverage 79.68% 79.68%
=======================================
Files 105 105
Lines 9822 9822
Branches 1582 1582
=======================================
Hits 7827 7827
Misses 1517 1517
Partials 478 478
Continue to review full report at Codecov.
|
fmassa
approved these changes
Mar 30, 2021
fmassa
changed the title
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 13, 2021
…ckling (#3620) Summary: * Update URLS of detection models * Empty commit after setting read permission on S3 Reviewed By: NicolasHug Differential Revision: D27706954 fbshipit-source-id: 3c560abe41688f7d3b2fa8792e8f157c89a4fb81 Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: The title of this PR is wrong (my bad): it's detection models, not classification
Follow up to #3581
Fixes #2068 - weights are unchanged, but the files can now be properly unpickled.
The new pth files have been uploaded to the S3 bucket and to the FB internal db.
For ref, here's the script that was used: https://nbviewer.jupyter.org/gist/NicolasHug/fb2c28d758951959da94d3db326ce21b