Skip to content

pip install from PyPI #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2017
Merged

pip install from PyPI #30

merged 1 commit into from
Jan 19, 2017

Conversation

graingert
Copy link

No description provided.

@soumith
Copy link
Member

soumith commented Jan 19, 2017

let me know when the pip package is in pypi, i'll pull this in. thx!

@graingert
Copy link
Author

graingert commented Jan 19, 2017

@soumith to put the package on PyPI I'll need another version bump. Also what's your username on PyPI (register here: https://pypi.org/account/register/ ) so I can add you as a maintainer

@soumith
Copy link
Member

soumith commented Jan 19, 2017

hmmm, can we avoid the version bump? the current version is 0.1.6 across torch and torchvision and I dont want that to change at the moment.
My pypi username is: soumith

@graingert
Copy link
Author

@soumith no. PyPI are very strict on that. You can't re-upload a new version of the same version.

@graingert
Copy link
Author

@soumith you can upload packages to torch and torchvision now

@soumith
Copy link
Member

soumith commented Jan 19, 2017

hmm ok i will change the vision version in the setup.py for now to 0.1.6.1 if that's okay

@soumith
Copy link
Member

soumith commented Jan 19, 2017

actually, i see that the package is already on pypi. why do you need another version bump? just curious. https://pypi.python.org/pypi/torchvision/0.1.6

@graingert
Copy link
Author

@soumith master currently has new code in it. To deploy new code you need to give it a new version

@graingert
Copy link
Author

0.1.6.1 isn't a valid semver version

@soumith
Copy link
Member

soumith commented Jan 19, 2017

ok first i'm going to be pushing master into the branch v0.1.6
And then let's freeze 0.1.6 as-is. The pytorch version has been frozen as well.

After that, I'll simply empty-bump both version to 0.1.7 :-/

@soumith
Copy link
Member

soumith commented Jan 19, 2017

ok i have version bumped it to 0.1.7 and frozen it.

@soumith
Copy link
Member

soumith commented Jan 19, 2017

you can use the branch v0.1.7 to build the wheels.

@graingert
Copy link
Author

If you do python3 setup.py sdist bdist_wheel upload

@graingert
Copy link
Author

It should package it and upload it for you

@soumith
Copy link
Member

soumith commented Jan 19, 2017

thank you, i'll try that

@soumith
Copy link
Member

soumith commented Jan 19, 2017

this worked :)

python setup.py sdist bdist_wheel
twine upload dist/torchvision-0.1.7-py2.py3-none-any.whl

it is live. Thank you for all your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants