Skip to content

Updated video classification ref example with new transforms #2935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 2, 2020

Conversation

vfdev-5
Copy link
Collaborator

@vfdev-5 vfdev-5 commented Oct 29, 2020

Description:

  • Added README
  • Updated example's transforms.py
  • Updated train.py

@vfdev-5 vfdev-5 requested review from fmassa and bjuncek October 30, 2020 08:53
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

I would have done the function / class differently. It's better if we have the reference codes to show what we would like users to do with the code.

Indeed, if we start showing that users can mix classes / functions, we will have less control in the future about what types of things we would be able to change / refactor.

On a different note, @bjuncek can you send a follow-up PR improving the readme with more information about how to train the model?


### Multiple GPUs

Run the training on a single node with 8 GPUs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @bjuncek trained those models on 64 GPUs, it might be good to add a mention here in a follow-up PR

@@ -0,0 +1,33 @@
# Video Classification

TODO: Add some info about the context, dataset we use etc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjuncek can you enhance this with information that you used to train on the datasets? We could potentially refer to submitit

@bjuncek
Copy link
Contributor

bjuncek commented Nov 2, 2020

Hi @fmassa and @vfdev-5,

I'll fill out these information (and test it out on a distributed cluster) sometime tomorrow before signing it off. :)

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #2935 into master will decrease coverage by 2.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2935      +/-   ##
==========================================
- Coverage   73.41%   71.23%   -2.18%     
==========================================
  Files          99       99              
  Lines        8801     8765      -36     
  Branches     1389     1389              
==========================================
- Hits         6461     6244     -217     
- Misses       1915     2105     +190     
+ Partials      425      416       -9     
Impacted Files Coverage Δ
torchvision/transforms/_functional_video.py 21.42% <0.00%> (-73.81%) ⬇️
torchvision/io/__init__.py 44.82% <0.00%> (-44.83%) ⬇️
torchvision/transforms/_transforms_video.py 46.03% <0.00%> (-42.86%) ⬇️
torchvision/extension.py 36.06% <0.00%> (-31.15%) ⬇️
torchvision/io/video.py 55.62% <0.00%> (-24.86%) ⬇️
torchvision/io/_video_opt.py 20.57% <0.00%> (-20.00%) ⬇️
torchvision/io/image.py 66.12% <0.00%> (-16.13%) ⬇️
torchvision/ops/deform_conv.py 67.74% <0.00%> (-3.23%) ⬇️
torchvision/__init__.py 61.11% <0.00%> (-2.78%) ⬇️
torchvision/datasets/kinetics.py 37.50% <0.00%> (-2.50%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36daee3...7ad5bdf. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@fmassa fmassa merged commit f95b053 into pytorch:master Nov 2, 2020
bryant1410 pushed a commit to bryant1410/vision-1 that referenced this pull request Nov 22, 2020
…#2935)

* [WIP] Update ref example video classification

* [WIP] Updated video classification ref example

* Replaced mem format conversion functions by classes
vfdev-5 added a commit to Quansight/vision that referenced this pull request Dec 4, 2020
…#2935)

* [WIP] Update ref example video classification

* [WIP] Updated video classification ref example

* Replaced mem format conversion functions by classes
@vfdev-5 vfdev-5 deleted the vfdev-5/update-ref-video-classif branch February 7, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants