PR: Remove linux distribution detection, search first on local paths for libraries #2457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2457 +/- ##
=======================================
Coverage 70.69% 70.69%
=======================================
Files 94 94
Lines 7920 7920
Branches 1249 1249
=======================================
Hits 5599 5599
Misses 1934 1934
Partials 387 387 Continue to review full report at Codecov.
|
|
@t-vi please let us know if you still have issues compiling torchvision even after this PR has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2398 (comment)
This PR removes the need for checking which Linux distribution is being used, additionally it modifies the discovery order of the external libraries, so that
TORCHVISION_INCLUDEcome first, then conda and finally the standard paths