fix a bug when video decoding fails and empty frames are returned #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
approved these changes
Oct 21, 2019
| @@ -137,12 +137,14 @@ def _read_from_stream(container, start_offset, end_offset, pts_unit, stream, str | |||
| pass | |||
| # ensure that the results are sorted wrt the pts | |||
| result = [frames[i] for i in sorted(frames) if start_offset <= frames[i].pts <= end_offset] | |||
| if start_offset > 0 and start_offset not in frames: | |||
| if len(frames) > 0 and start_offset > 0 and start_offset not in frames: | |||
There was a problem hiding this comment.
nit: this check in here is not necessary. Only the second one if len(preceding_framses) > 0) is actually necessary I believe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when video decoding fails, no frame is returned.
function
maxwill fail during the callmax(i for i in frames if i < start_offset)whenframesis empty.