A fix for one line comment when removing runnable code. #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit 94eb7c6 https://deploy-preview-1165--pytorch-tutorials-preview.netlify.app |
brianjo
added a commit
that referenced
this pull request
Sep 24, 2020
* Fix typo (#1118) In PyTorch tutorial, `torch` should be installed rather than `torchaudio` * Recover the attributes of torch in memory_format_tutorial (#1112) Co-authored-by: Brian Johnson <[email protected]> * fix bugs for data_loading_tutorial and dcgan_faces_tutorial (#1092) * Update autocast in dispatcher tutorial (#1128) * draft * fixes * dont overrun the line * Corrected model.resnet50() spelling (#1139) Spelling mistake led to errors for beginners. * Fix typo & Minor changes (#1138) Thanks for the fixes @codingbowoo! * Run win_test_worker manually (#1142) Merging to clean up a build issue. * Disable `pytorch_windows_builder_worker` config (#1143) See #1141 * Update index.rst (#1140) Fixed incorrect link. * Update index.rst Fix to broken link. * LSTM's -> LSTMs in equence_models_tutorial.py docs (#1136) Co-authored-by: Brian Johnson <[email protected]> * Added Ray Tune Hyperparameter Tuning Tutorial (#1066) * Added Ray Tune Hyperparameter Tuning Tutorial * Use nightly ray release * Fix checkpoint API Co-authored-by: Brian Johnson <[email protected]> * Fix typo in "Introduction to Pytorch" tutorial (in NLP tutorial) (#1145) * Fix typo in "Introduction to Pytorch" tutorial (in Pytorch for NLP tutorials) * Dummy commit, to restart CI * Revert dummy commit, to restart CI * Revert whitespace changes * Install torch not torch vision (#1153) Small update to recipe that instructs users to install `torch` not `torchaudio` * Python recipe for automatic mixed precision (#1137) * fdsa * Tutorial runs * clarify one scaler per convergence run * adjust sizes, dont run illustrative sections * satisfying ocd * MORE * fdsa * details * rephrase * fix formatting * move script to recipes * hopefully moved to recipes * fdsa * add amp_tutorial to toctree * amp_tutorial -> amp_recipe * looks like backtick highlights dont render in card_description * correct path for amp_recipe.html * arch notes and saving/restoring * formatting * fdsa * Clarify autograd-autocast interaction for custom ops * touchups Co-authored-by: Brian Johnson <[email protected]> * Fix model to be properly exported to ONNX (#1144) Co-authored-by: Brian Johnson <[email protected]> * Dist rpc merge (#1158) * Create distributed_rpc_profiling.rst * Update recipes_index.rst * Add files via upload * Update recipes_index.rst * Fix typo "asynchronizely" -> "asynchronously" (#1154) * Update dist_overview with additional information. (#1155) Summary: 1) Added DDP + RPC tutorial. 2) Added a pointer to PT Distributed CONTRIBUTING.md. Test Plan: Verified by loading the page locally. Reviewers: sentinel Subscribers: Tasks: Tags: Co-authored-by: pritam <[email protected]> * Add Performance Tuning guide recipe (#1161) * Performance Tuning Guide - initial commit * Minor tweaks * Switched profiling guide thumbnail to pytorch logo * Converted Tuning Guide to 80 chars/line * Split tuning guide into general, GPU-specific and distributed optimizations. * WAR to fix generation of header for 1st section * Minor fixes * Implemented changes suggested during initial review * Changed 'addition assignment' to 'addition' * Removed sentences about 1 CPU core for DataParallel training * Reordering of layers is recommended only for DDP(find_unused_parameters=True) * Fixed formatting * s/constructors/model constructors and s/match/roughly match * Fixed typos * A fix for one line comment when removing runnable code. (#1165) Co-authored-by: v-jizhang <[email protected]> Co-authored-by: Nikita Shulga <[email protected]> Co-authored-by: guyang3532 <[email protected]> Co-authored-by: mcarilli <[email protected]> Co-authored-by: Sayantan Das <[email protected]> Co-authored-by: 장보우 Bowoo Jang <[email protected]> Co-authored-by: Alan deLevie <[email protected]> Co-authored-by: krfricke <[email protected]> Co-authored-by: Vijay Viswanathan <[email protected]> Co-authored-by: J. Randall Hunt <[email protected]> Co-authored-by: Thiago Crepaldi <[email protected]> Co-authored-by: Peter Whidden <[email protected]> Co-authored-by: Pritam Damania <[email protected]> Co-authored-by: pritam <[email protected]> Co-authored-by: Szymon Migacz <[email protected]> Co-authored-by: Jinlin Zhang <[email protected]> Co-authored-by: v-jizhang <[email protected]>
subramen
pushed a commit
to subramen/tutorials
that referenced
this pull request
Feb 1, 2021
Co-authored-by: v-jizhang <[email protected]>
cassiebreviu
added a commit
to sethjuarez/tutorials
that referenced
this pull request
Feb 1, 2021
* refactor - till custom datasets * Updated data * updated buildmodel * update the other sections * final edits * A fix for one line comment when removing runnable code. (pytorch#1165) Co-authored-by: v-jizhang <[email protected]> * Update tutorials to use TensorPipeRpcBackendOptions. (pytorch#1164) * Update tutorials to use TensorPipeRpcBackendOptions. * Commit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Commit2 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: pritam <[email protected]> * Update dynamic quant tutorial for saving quantized model (pytorch#1167) Summary: Addresses pytorch/pytorch#43016 Test Plan: Reviewers: Subscribers: Tasks: Tags: * retitle dispatcher tutorial (pytorch#1168) * minor typo fixes (pytorch#1160) Co-authored-by: Brian Johnson <[email protected]> * Update saving_loading_models.py (pytorch#1173) * Removes Outdated Trainer Tutorial (pytorch#1181) * Update index.rst * Delete aws_distributed_training_tutorial.py * complete PyTorch quickstart proposal * Formatting and wording updates (#27) * corrected rebase errors * Some updates based on feedback to quickstart and build model (#29) * Added more detail to the intro of the quickstart * primitive dataset text update * fix build model * updated quickstart to class model (#30) * fix build model * updated quickstart to class model * Updates to quickstart main page, build model page based on feedback (#31) * updates to load class model, build model page work * more work on build model * small formatting fix on build model page (#32) * fix formating on build model page * build model formatting fixes (#33) * build model format fix * Update build_model_tutorial.py * Update build_model_tutorial.py * Update optimization_tutorial.py fixed footer * Update data_quickstart_tutorial.py fix image on data * Update data_quickstart_tutorial.py (#34) Addressed open comments * Update data_quickstart_tutorial.py (#35) Fixed links and formatting * Update data_quickstart_tutorial.py removed github markup * Update data_quickstart_tutorial.py * Update build_model_tutorial.py * Update data_quickstart_tutorial.py (#36) * build model section updates, breadcrumb test, linear wording fix (#37) * removed full top ex, moved sequential to layer ex * fixed linear layer wording * breadcrumb test * move TOC (#39) * removed full top ex, moved sequential to layer ex * fixed linear layer wording * breadcrumb test * rename for auto breadcrumb for tutorials * move table of contents to top * toc fix probably (#40) * how to use this guide text (#41) * removed code blocks moved toc (#42) * Make misc improvements to quickstart (#43) * Refactor buildmodel_tutorial.py to exclude sequential net definition (#44) * moved quickstart home folder, added breadcrumb * add callout quickstart on tutorials page, cap fix * checkin by Cassie: how to run code, fixed typo * checked in by cassie: quickstart updates typo fix * Refactor optimization tutorial * Formatting fixes to optimization tutorial * quickstart home page updates * tensor page edits * cassie checkin: data page review * Update save-load-run quickstart tutorial * checkin by cassie: review/fix transforms page * checkin by cassie: Fixed build model page * checkin by cassie: optimization page, add setup * autograd and optimzation page updates * checkin by cassie: save run load page review * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/autograd_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/autograd_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * checkin by cassie: fix spacing * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * fix link * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * fix link * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * cassie checkin: add next prev links * fix links * fix links * toc tree test * cassie checkin: removed old next prev * Fix missing variable in saveloadrun_tutorial * Update beginner_source/quickstart/quickstart_tutorial.py * "DataSet" -> "Dataset" * Apply suggestions from code review -- buildmodel * add links to author names * formatting * add suraj as author * add loading dataset to data quickstart * init fucntion wording update on datasets * added iterate to datasets section * update quickstart title to 'learn the basics' * refactor - till custom datasets * Updated data * updated buildmodel * update the other sections * final edits Co-authored-by: Jinlin Zhang <[email protected]> Co-authored-by: v-jizhang <[email protected]> Co-authored-by: Pritam Damania <[email protected]> Co-authored-by: pritam <[email protected]> Co-authored-by: supriyar <[email protected]> Co-authored-by: Basil Hosmer <[email protected]> Co-authored-by: Jeff Tang <[email protected]> Co-authored-by: Brian Johnson <[email protected]> Co-authored-by: Yuxin Wu <[email protected]> Co-authored-by: sethjuarez <[email protected]> Co-authored-by: Cassie <[email protected]> Co-authored-by: PythicCoder <[email protected]> Co-authored-by: Dmitri Soshnikov <[email protected]> Co-authored-by: Cassie Breviu <[email protected]>
cassiebreviu
added a commit
to sethjuarez/tutorials
that referenced
this pull request
Feb 5, 2021
* refactor - till custom datasets * Updated data * updated buildmodel * update the other sections * final edits * A fix for one line comment when removing runnable code. (pytorch#1165) Co-authored-by: v-jizhang <[email protected]> * Update tutorials to use TensorPipeRpcBackendOptions. (pytorch#1164) * Update tutorials to use TensorPipeRpcBackendOptions. * Commit Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * Commit2 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Co-authored-by: pritam <[email protected]> * Update dynamic quant tutorial for saving quantized model (pytorch#1167) Summary: Addresses pytorch/pytorch#43016 Test Plan: Reviewers: Subscribers: Tasks: Tags: * retitle dispatcher tutorial (pytorch#1168) * minor typo fixes (pytorch#1160) Co-authored-by: Brian Johnson <[email protected]> * Update saving_loading_models.py (pytorch#1173) * Removes Outdated Trainer Tutorial (pytorch#1181) * Update index.rst * Delete aws_distributed_training_tutorial.py * complete PyTorch quickstart proposal * Formatting and wording updates (#27) * corrected rebase errors * Some updates based on feedback to quickstart and build model (#29) * Added more detail to the intro of the quickstart * primitive dataset text update * fix build model * updated quickstart to class model (#30) * fix build model * updated quickstart to class model * Updates to quickstart main page, build model page based on feedback (#31) * updates to load class model, build model page work * more work on build model * small formatting fix on build model page (#32) * fix formating on build model page * build model formatting fixes (#33) * build model format fix * Update build_model_tutorial.py * Update build_model_tutorial.py * Update optimization_tutorial.py fixed footer * Update data_quickstart_tutorial.py fix image on data * Update data_quickstart_tutorial.py (#34) Addressed open comments * Update data_quickstart_tutorial.py (#35) Fixed links and formatting * Update data_quickstart_tutorial.py removed github markup * Update data_quickstart_tutorial.py * Update build_model_tutorial.py * Update data_quickstart_tutorial.py (#36) * build model section updates, breadcrumb test, linear wording fix (#37) * removed full top ex, moved sequential to layer ex * fixed linear layer wording * breadcrumb test * move TOC (#39) * removed full top ex, moved sequential to layer ex * fixed linear layer wording * breadcrumb test * rename for auto breadcrumb for tutorials * move table of contents to top * toc fix probably (#40) * how to use this guide text (#41) * removed code blocks moved toc (#42) * Make misc improvements to quickstart (#43) * Refactor buildmodel_tutorial.py to exclude sequential net definition (#44) * moved quickstart home folder, added breadcrumb * add callout quickstart on tutorials page, cap fix * checkin by Cassie: how to run code, fixed typo * checked in by cassie: quickstart updates typo fix * Refactor optimization tutorial * Formatting fixes to optimization tutorial * quickstart home page updates * tensor page edits * cassie checkin: data page review * Update save-load-run quickstart tutorial * checkin by cassie: review/fix transforms page * checkin by cassie: Fixed build model page * checkin by cassie: optimization page, add setup * autograd and optimzation page updates * checkin by cassie: save run load page review * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/dataquickstart_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/transforms_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/autograd_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/autograd_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/buildmodel_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * checkin by cassie: fix spacing * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * fix link * Update beginner_source/quickstart/optimization_tutorial.py Co-authored-by: suraj813 <[email protected]> * fix link * Update beginner_source/quickstart/saveloadrun_tutorial.py Co-authored-by: suraj813 <[email protected]> * cassie checkin: add next prev links * fix links * fix links * toc tree test * cassie checkin: removed old next prev * Fix missing variable in saveloadrun_tutorial * Update beginner_source/quickstart/quickstart_tutorial.py * "DataSet" -> "Dataset" * Apply suggestions from code review -- buildmodel * add links to author names * formatting * add suraj as author * add loading dataset to data quickstart * init fucntion wording update on datasets * added iterate to datasets section * update quickstart title to 'learn the basics' * refactor - till custom datasets * Updated data * updated buildmodel * update the other sections * final edits * update index.rst * delete devcontainer and gh workflows * restore index.rst - update with separate PR Co-authored-by: Jinlin Zhang <[email protected]> Co-authored-by: v-jizhang <[email protected]> Co-authored-by: Pritam Damania <[email protected]> Co-authored-by: pritam <[email protected]> Co-authored-by: supriyar <[email protected]> Co-authored-by: Basil Hosmer <[email protected]> Co-authored-by: Jeff Tang <[email protected]> Co-authored-by: Brian Johnson <[email protected]> Co-authored-by: Yuxin Wu <[email protected]> Co-authored-by: sethjuarez <[email protected]> Co-authored-by: Cassie <[email protected]> Co-authored-by: PythicCoder <[email protected]> Co-authored-by: Dmitri Soshnikov <[email protected]> Co-authored-by: Cassie Breviu <[email protected]>
rodrigo-techera
pushed a commit
to Experience-Monks/tutorials
that referenced
this pull request
Nov 29, 2021
Co-authored-by: v-jizhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for one line comment when removing runnable code.