-
Notifications
You must be signed in to change notification settings - Fork 619
Enabling User2 workflow #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Would it make sense to surface the recipes in the docs themselves? The nice thing here is that docs are versioned so you can reference the docs that match your pip version. If you git clone and I'm not against a script, but I think it could be more intuitive if the user just directly interacts with our docs and pip (unless they prefer to git clone). |
Having the recipes in the docs sounds like a reasonable option, as long as we're already 100% sure that a recipe can be rendered on a single doc page, and that this is all the user is going to need to run the recipe. What does that mean for example for configs? |
This is definitely an open question. I think it's doable and could be a very good goal for keeping our recipes readable but we still have to figure out the details. I think we need an example of a config, coming together with a first example of the entry point, along with some initial version of the docs. |
Uh oh!
There was an error while loading. Please reload this page.
This is a follow-up to the discussion we had yesterday on the team meeting.
User2 is defined in @pbontrager 's #54
The Problem
I'm user 2. My workflow typically is to copy a recipe from torchtune, edit it to my needs, and run it.
That's the part that we need to very clearly define.
main
branch of the torchtune repo?main
branch, it's tracking the dev version of torchtune, and it probably contains some code and utilities that I don't have access to in my stable torchtune version. So I can't run it :(tochtune
was installed? (e.g. some very-hard-to-fine-place like/home/nicolashug/.miniconda3/envs/myenv/lib/python3.10/site-packages/torchtune/assets
??)We need a blessed way to copy/paste the training recipes for a given stable version of torchtune
It's important to understand that this problem exists regardless of the repo structure that we have, and regardless of whether we are bundling the recipes as part of the package, or as assets/resources.
BTW, to enable User1 workflow, having the recipes as assets / resources in the package is probably a good solution, as Philip already suggested in other channels.
Back to User2: I don't have a perfect solution to suggest, I just wanted to flag something we need to think about. Some random thoughts:
This would make sure to have the proper
finetune_llm.py
file with the appropriate configs, etc.?(by default, the version would just be the current version of
torchtune
)The text was updated successfully, but these errors were encountered: