Skip to content

style: add move model print #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2024
Merged

style: add move model print #1037

merged 3 commits into from
Aug 19, 2024

Conversation

kuizhiqing
Copy link
Contributor

After run

python3 torchchat.py download llama3.1

the last print would be

Converting meta-llama/Meta-Llama-3.1-8B-Instruct to torchchat format...██████████| 9.09M/9.09M [00:02<00:00, 3.43MB/s]
known configs: ['13B', '70B', 'CodeLlama-7b-Python-hf', '34B', 'Meta-Llama-3.1-8B', 'stories42M', '30B', 'stories110M', 'Meta-Llama-3.1-70B', '7B', 'stories15M', 'Mistral-7B', 'Meta-Llama-3-70B', 'Meta-Llama-3-8B']
Model config {'block_size': 2048, 'vocab_size': 128256, 'n_layers': 32, 'n_heads': 32, 'dim': 4096, 'hidden_dim': 14336, 'n_local_heads': 8, 'head_dim': 128, 'rope_base': 500000.0, 'norm_eps': 1e-05, 'multiple_of': 1024, 'ffn_dim_multiplier': 1.3, 'use_tiktoken': True, 'max_seq_length': 8192, 'use_scaled_rope': True}
Moving checkpoint to /Users/joeque/.torchchat/model-cache/downloads/meta-llama/Meta-Llama-3.1-8B-Instruct/model.pth.
Done.

from function download_and_convert, it was confusing that we cannot find any files in it.

I've found that the dir printed was a tmep dir and there is a move action in download.py,
So, add a print before move would be better.

Copy link

pytorch-bot bot commented Aug 16, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1037

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 230e14d with merge base 147c292 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 16, 2024
Copy link
Contributor

@Jack-Khuu Jack-Khuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@Jack-Khuu Jack-Khuu merged commit 1566512 into pytorch:main Aug 19, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants