Skip to content

Hide generate_time(ms) metric temporarily #6314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2025

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Feb 21, 2025

Due to pytorch/executorch#8576 (comment)

As we cannot go back and update historical data, we could hide generate_time(ms) for a week or two till there are new data. Maybe it could also be hidden permanently if we decide to keep only TPS metric.

Preview

https://torchci-git-fork-huydhn-hide-generate-time-0f0c4f-fbopensource.vercel.app/benchmark/llms?repoName=pytorch%2Fexecutorch

@huydhn huydhn requested a review from guangy10 February 21, 2025 01:57
Copy link

vercel bot commented Feb 21, 2025

@huydhn is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 21, 2025
Copy link

vercel bot commented Feb 21, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Feb 22, 2025 1:19am

@guangy10
Copy link

fyi: @kirklandsign Once this is merged, Android will not show generate_time neither.

Copy link

@guangy10 guangy10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huydhn huydhn merged commit aefee25 into pytorch:main Feb 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants