Skip to content

[CH] Remove various mentions of Rockset in comments and variable names #6042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

clee2000
Copy link
Contributor

Remove rockset from variable names, workflow names, and comments.

This is non exhaustive, but it helps reduce the results when I search for Rockset in the codebase

@clee2000 clee2000 marked this pull request as ready for review December 11, 2024 18:37
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Dec 11, 2024 6:37pm

@clee2000 clee2000 requested a review from a team December 11, 2024 18:37
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2024
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clee2000 clee2000 merged commit 9620f4f into main Dec 11, 2024
16 checks passed
@clee2000 clee2000 deleted the csl/ch_assorted_non_ts branch December 11, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants