Skip to content

Make functorch compilable with Py-3.11 #85054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Make functorch compilable with Py-3.11 #85054

wants to merge 3 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Sep 14, 2022 •
edited
Loading

By using compatibility wrappers from python_compat.h and skipping part of getname switch

Fixes #85006

Please note that import torch right now fails by default on 3.11 with some jit issue, so I think this shouldn't be a really issue for a bit

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 14, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85054

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 Failures

As of commit 4f11bd8:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet
Copy link
Contributor Author

malfet commented Sep 21, 2022

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased malfet-patch-8 onto refs/remotes/origin/master, please pull locally before adding more changes (for example, via git checkout malfet-patch-8 && git pull --rebase)

@malfet malfet force-pushed the malfet-patch-8 branch 2 times, most recently from 83b5506 to 4881be8 Compare September 22, 2022 01:23
@malfet malfet requested review from zou3519 and a team September 22, 2022 01:24
@zou3519
Copy link
Contributor

zou3519 commented Sep 22, 2022

Test failures look legit

@malfet malfet force-pushed the malfet-patch-8 branch 2 times, most recently from 2c29774 to cb8bcd5 Compare September 22, 2022 17:05
@malfet
Copy link
Contributor Author

malfet commented Sep 22, 2022 •
edited
Loading

Test failures look legit

Yeah, because wrappers/3.10+ code takes strong references, but current dims.cpp assumes they are weak ones. Modified description.

@malfet malfet added the ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR label Sep 22, 2022
zdevito
zdevito approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@zdevito zdevito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing this!

@malfet
Copy link
Contributor Author

malfet commented Sep 23, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@malfet malfet added topic: not user facing topic category release notes: torch.func release notes category for torch.vmap or torch.func.* APIs labels Sep 23, 2022
@malfet malfet deleted the malfet-patch-8 branch September 23, 2022 04:49
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@malfet @mehtanirav
Make functorch compilable with Py-3.11 (#85054)
e859de3 
By using compatibility wrappers from [python_compat.h](https://github.com/pytorch/pytorch/blob/master/torch/csrc/utils/python_compat.h) and skipping part of `getname` switch

Fixes #85006

Please note that `import torch` right now fails by default on 3.11 with some jit issue, so I think this shouldn't be a really issue for a bit
Pull Request resolved: #85054
Approved by: https://github.com/kit1980, https://github.com/zdevito
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zdevito zdevito zdevito approved these changes

@kit1980 kit1980 kit1980 approved these changes

@zou3519 zou3519 Awaiting requested review from zou3519

Assignees
No one assigned
Labels
ciflow/binaries_wheel Trigger binary build and upload jobs for wheel on the PR cla signed Merged release notes: torch.func release notes category for torch.vmap or torch.func.* APIs topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.11 Wheels are broken by functorch commit
6 participants
@malfet @pytorchmergebot @zou3519 @zdevito @kit1980 @facebook-github-bot