Remove cuda dependencies from non cuda buids #152333

atalman · 2025-04-28T15:07:35Z

These dependancies added to fix poetry issue on pypi. However inclusion of these dependencies creates issue with poetry on download.pytorch.org due to poetry reading first available wheel on index for METADATA requirements. Hence all metadata requirements for CPU wheels can't list any cuda dependencies.

Injecting these dependencies via prep for pypi will need to be done via:
https://github.com/pytorch/test-infra/blob/main/release/pypi/prep_binary_for_pypi.sh

Ref: #152121

pytorch-bot · 2025-04-28T15:07:39Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152333

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 111 Pending

As of commit 572b6a2 with merge base 9c864f9 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jeanschmidt

LGTM

atalman · 2025-04-28T16:44:29Z

@pytorchmergebot merge -f "lint and binary builds look good"

pytorchmergebot · 2025-04-28T16:46:32Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

atalman · 2025-05-07T18:49:23Z

@pytorchbot cherry-pick --onto release/2.7 -c critical

pytorchbot · 2025-05-07T18:54:42Z

Cherry picking #152333

Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x c8698628758ba32ca8a1d4babcda59114b51ec03 returned non-zero exit code 1

Auto-merging .github/scripts/generate_binary_build_matrix.py
Auto-merging .github/workflows/generated-linux-aarch64-binary-manywheel-nightly.yml
Auto-merging .github/workflows/generated-linux-s390x-binary-manywheel-nightly.yml
Auto-merging .github/workflows/generated-macos-arm64-binary-wheel-nightly.yml
Auto-merging .github/workflows/generated-windows-arm64-binary-wheel-nightly.yml
CONFLICT (content): Merge conflict in .github/workflows/generated-windows-arm64-binary-wheel-nightly.yml
Auto-merging .github/workflows/generated-windows-binary-wheel-nightly.yml
error: could not apply c8698628758... Remove cuda dependencies from non cuda buids (#152333)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

…153089) * Remove cuda dependencies from non cuda buids * regenerate * regenerate

) We require Wheel file manipulation stripping suffixes. Also from time to time we inject requirements into wheel METADATA to work around limitations with poetry. Using python and auditwheel make it simplier to modify and maintain this script. For example no RECORD file regeneration with the new SHA is necessary, auditwheel does it for you. Preparing to do Metadata injection since it was removed by this PR: pytorch/pytorch#152333 Related to Poetry issue: pytorch/pytorch#152121 Testing: ``` DRY_RUN=disabled ./promote_pypi_to_staging.sh =-=-=-= Promoting torch's v2.7.1 to pypi staging' =-=-=-= + PACKAGE_VERSION=2.7.1 + PACKAGE_NAME=torch + DRY_RUN=disabled + bash /home/ec2-user/github/test-infra-r27/release/pypi/upload_pypi_to_staging.sh Requesting cu126 https://download.pytorch.org/whl/test/cu126/torch/index.html For torch-2.7.1%2Bcu126 /tmp/tmp.sGF5bXVuGs ~/github/test-infra-r27/release/pypi Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp310-cp310-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp310-cp310-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp310-cp310-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 784M 100 784M 0 0 34.7M 0 0:00:22 0:00:22 --:--:-- 37.8M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp310-cp310-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl + ls -las total 801912 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:24 . 0 drwxrwxrwt. 17 root root 380 May 29 16:24 .. 801912 -rw-r--r--. 1 ec2-user ec2-user 821154516 May 29 16:24 torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp310-cp310-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp311-cp311-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp311-cp311-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp311-cp311-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 784M 100 784M 0 0 32.4M 0 0:00:24 0:00:24 --:--:-- 34.6M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp311-cp311-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl + ls -las total 801932 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:26 . 0 drwxrwxrwt. 17 root root 380 May 29 16:26 .. 801932 -rw-r--r--. 1 ec2-user ec2-user 821174704 May 29 16:26 torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp311-cp311-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp312-cp312-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp312-cp312-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp312-cp312-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 783M 100 783M 0 0 34.0M 0 0:00:23 0:00:23 --:--:-- 37.1M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp312-cp312-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl + ls -las total 801784 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:28 . 0 drwxrwxrwt. 17 root root 380 May 29 16:28 .. 801784 -rw-r--r--. 1 ec2-user ec2-user 821025792 May 29 16:28 torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp312-cp312-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp313-cp313-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp313-cp313-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp313-cp313-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 783M 100 783M 0 0 34.5M 0 0:00:22 0:00:22 --:--:-- 39.1M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp313-cp313-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl + ls -las total 801792 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:31 . 0 drwxrwxrwt. 17 root root 380 May 29 16:31 .. 801792 -rw-r--r--. 1 ec2-user ec2-user 821033192 May 29 16:31 torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp313-cp313-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp313-cp313t-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp313-cp313t-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp313-cp313t-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 783M 100 783M 0 0 29.9M 0 0:00:26 0:00:26 --:--:-- 31.4M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp313-cp313t-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl + ls -las total 801856 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:33 . 0 drwxrwxrwt. 17 root root 380 May 29 16:33 .. 801856 -rw-r--r--. 1 ec2-user ec2-user 821098066 May 29 16:33 torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp313-cp313t-manylinux_2_28_x86_64.whl Processing /whl/test/cu126/torch-2.7.1%2Bcu126-cp39-cp39-manylinux_2_28_x86_64.whl + curl -fSL -o /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp39-cp39-manylinux_2_28_x86_64.whl https://download.pytorch.org/whl/test/cu126/torch-2.7.1%2Bcu126-cp39-cp39-manylinux_2_28_x86_64.whl % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 784M 100 784M 0 0 33.0M 0 0:00:23 0:00:23 --:--:-- 32.0M preparing wheel in /home/ec2-user/github/test-infra-r27/release/pypi Processing wheel: /tmp/tmp.QKhLmXhoxI/torch-2.7.1%2Bcu126-cp39-cp39-manylinux_2_28_x86_64.whl Removing suffix: 2.7.1+cu126 -> 2.7.1 Renaming torch-2.7.1.dist-info Successfully created: /tmp/tmp.sGF5bXVuGs/torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl + ls -las total 801904 0 drwx------. 2 ec2-user ec2-user 60 May 29 16:35 . 0 drwxrwxrwt. 17 root root 380 May 29 16:35 .. 801904 -rw-r--r--. 1 ec2-user ec2-user 821146689 May 29 16:35 torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl + aws s3 cp torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl s3://pytorch-backup/torch-2.7.1-pypi-staging/ upload: ./torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl to s3://pytorch-backup/torch-2.7.1-pypi-staging/torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl + rm -rf ./torch-2.7.1-cp39-cp39-manylinux_2_28_x86_64.whl ```

Remove cuda dependencies from non cuda buids

572b6a2

atalman requested a review from a team as a code owner April 28, 2025 15:07

pytorch-bot bot added the topic: not user facing topic category label Apr 28, 2025

atalman added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Apr 28, 2025

jeanschmidt approved these changes Apr 28, 2025

View reviewed changes

malfet approved these changes Apr 28, 2025

View reviewed changes

pytorchmergebot added the merging label Apr 28, 2025

pytorchmergebot closed this in c869862 Apr 28, 2025

pytorchmergebot added Merged and removed merging labels Apr 28, 2025

This was referenced May 7, 2025

[Cherry Pick] Remove cuda dependencies from non cuda buids #152333 #153089

Merged

[v2.7.1] Release Tracker #152627

Closed

atalman added a commit that referenced this pull request May 7, 2025

[Cherry Pick] Remove cuda dependencies from non cuda buids #152333 (#…

cd885e7

…153089) * Remove cuda dependencies from non cuda buids * regenerate * regenerate

atalman added this to the 2.7.1 milestone May 8, 2025

This was referenced May 28, 2025

Release 2.7.1 validations checklist and cherry-picks #154512

Closed

[BE] Use python script and auditwheel for wheel file manipulation pytorch/test-infra#6679

Merged

atalman mentioned this pull request May 29, 2025

[poetry] when running prep_binary_for_pypi inject linux metadata to all wheels pytorch/test-infra#6681

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove cuda dependencies from non cuda buids #152333

Remove cuda dependencies from non cuda buids #152333

atalman commented Apr 28, 2025

Uh oh!

pytorch-bot bot commented Apr 28, 2025 •

edited

Loading

Uh oh!

jeanschmidt left a comment

Uh oh!

atalman commented Apr 28, 2025

Uh oh!

pytorchmergebot commented Apr 28, 2025

Uh oh!

atalman commented May 7, 2025

Uh oh!

pytorchbot commented May 7, 2025

Uh oh!

Uh oh!

Remove cuda dependencies from non cuda buids #152333

Remove cuda dependencies from non cuda buids #152333

Conversation

atalman commented Apr 28, 2025

Uh oh!

pytorch-bot bot commented Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/152333

⏳ No Failures, 111 Pending

Uh oh!

jeanschmidt left a comment

Choose a reason for hiding this comment

Uh oh!

atalman commented Apr 28, 2025

Uh oh!

pytorchmergebot commented Apr 28, 2025

Merge started

Uh oh!

atalman commented May 7, 2025

Uh oh!

pytorchbot commented May 7, 2025

Cherry picking #152333

Uh oh!

Uh oh!

pytorch-bot bot commented Apr 28, 2025 •

edited

Loading