Skip to content

Commit c98cb20

Browse files
committed
Introduce the PTI 0.11 into kineto
Signed-off-by: Chen, Zejun <[email protected]>
1 parent a054a4b commit c98cb20

File tree

3 files changed

+27
-7
lines changed

3 files changed

+27
-7
lines changed

libkineto/src/plugin/xpupti/XpuptiActivityApi.cpp

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,23 @@ void XpuptiActivityApi::bufferCompleted(
170170
}
171171
#endif
172172

173+
static void enableSpecifcRuntimeAPIsTracing() {
174+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueUSMFill_id));
175+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueUSMFill2D_id));
176+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueUSMMemcpy_id));
177+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueUSMMemcpy2D_id));
178+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueKernelLaunch_id));
179+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueKernelLaunchCustomExp_id));
180+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueCooperativeKernelLaunchExp_id));
181+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueMemBufferFill_id));
182+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueMemBufferRead_id));
183+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueMemBufferWrite_id));
184+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urEnqueueMemBufferCopy_id));
185+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMHostAlloc_id));
186+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMSharedAlloc_id));
187+
XPUPTI_CALL(ptiViewEnableRuntimeApi(1, pti_api_group_id::PTI_API_GROUP_SYCL, urUSMDeviceAlloc_id));
188+
}
189+
173190
void XpuptiActivityApi::enableXpuptiActivities(
174191
const std::set<ActivityType>& selected_activities) {
175192
#ifdef HAS_XPUPTI
@@ -192,7 +209,8 @@ void XpuptiActivityApi::enableXpuptiActivities(
192209
externalCorrelationEnabled_ = true;
193210
}
194211
if (activity == ActivityType::XPU_RUNTIME) {
195-
XPUPTI_CALL(ptiViewEnable(PTI_VIEW_SYCL_RUNTIME_CALLS));
212+
XPUPTI_CALL(ptiViewEnable(PTI_VIEW_RUNTIME_API));
213+
enableSpecifcRuntimeAPIsTracing();
196214
}
197215
if (activity == ActivityType::OVERHEAD) {
198216
XPUPTI_CALL(ptiViewEnable(PTI_VIEW_COLLECTION_OVERHEAD));
@@ -222,7 +240,7 @@ void XpuptiActivityApi::disablePtiActivities(
222240
XPUPTI_CALL(ptiViewDisable(PTI_VIEW_EXTERNAL_CORRELATION));
223241
}
224242
if (activity == ActivityType::XPU_RUNTIME) {
225-
XPUPTI_CALL(ptiViewDisable(PTI_VIEW_SYCL_RUNTIME_CALLS));
243+
XPUPTI_CALL(ptiViewDisable(PTI_VIEW_RUNTIME_API));
226244
}
227245
if (activity == ActivityType::OVERHEAD) {
228246
XPUPTI_CALL(ptiViewDisable(PTI_VIEW_COLLECTION_OVERHEAD));

libkineto/src/plugin/xpupti/XpuptiActivityHandlers.cpp

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,16 +98,18 @@ inline void XpuptiActivityProfilerSession::handleCorrelationActivity(
9898
}
9999

100100
void XpuptiActivityProfilerSession::handleRuntimeActivity(
101-
const pti_view_record_sycl_runtime* activity,
101+
const pti_view_record_api* activity,
102102
ActivityLogger* logger) {
103103
traceBuffer_.span.opCount += 1;
104104
traceBuffer_.gpuOpCount += 1;
105105
const ITraceActivity* linked =
106106
linkedActivity(activity->_correlation_id, cpuCorrelationMap_);
107+
const char* api_name = nullptr;
108+
ptiViewGetApiIdName(activity->_api_group, activity->_api_id, &api_name);
107109
traceBuffer_.emplace_activity(
108110
traceBuffer_.span,
109111
ActivityType::XPU_RUNTIME,
110-
std::string(activity->_name));
112+
std::string(api_name));
111113
auto& runtime_activity = traceBuffer_.activities.back();
112114
runtime_activity->startTime = activity->_start_timestamp;
113115
runtime_activity->endTime = activity->_end_timestamp;
@@ -331,9 +333,9 @@ void XpuptiActivityProfilerSession::handlePtiActivity(
331333
reinterpret_cast<const pti_view_record_external_correlation*>(
332334
record));
333335
break;
334-
case PTI_VIEW_SYCL_RUNTIME_CALLS:
336+
case PTI_VIEW_RUNTIME_API:
335337
handleRuntimeActivity(
336-
reinterpret_cast<const pti_view_record_sycl_runtime*>(record),
338+
reinterpret_cast<const pti_view_record_api*>(record),
337339
logger);
338340
break;
339341
case PTI_VIEW_DEVICE_GPU_KERNEL:

libkineto/src/plugin/xpupti/XpuptiActivityProfiler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class XpuptiActivityProfilerSession
5252
void handleCorrelationActivity(
5353
const pti_view_record_external_correlation* correlation);
5454
void handleRuntimeActivity(
55-
const pti_view_record_sycl_runtime* activity,
55+
const pti_view_record_api* activity,
5656
ActivityLogger* logger);
5757
void handleKernelActivity(
5858
const pti_view_record_kernel* activity,

0 commit comments

Comments
 (0)