Fix OSS compilation error (#176)

Ilia Cherniavskii · facebook-github-bot · commit b4e71c3a9e11 · 2021-04-19T19:58:27.000-07:00
Summary: Pull Request resolved: #176 In OSS not all builds support nodiscard https://app.circleci.com/pipelines/github/pytorch/pytorch/305130/workflows/1885277b-9d54-4637-ab9f-7234be2f2ee2/jobs/12588162 Reviewed By: dzhulgakov Differential Revision: D27872203 fbshipit-source-id: 711712f5b819fd4faf21da1c363b70960acf9518
diff --git a/libkineto/include/ClientTraceActivity.h b/libkineto/include/ClientTraceActivity.h
@@ -64,7 +64,7 @@ struct ClientTraceActivity : TraceActivity {
     metadata_.push_back(std::move(kv));
   }
 
-  [[nodiscard]] const std::string getMetadata() const {
+  const std::string getMetadata() const {
     return fmt::format("{}", fmt::join(metadata_, ", "));
   }
 

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ struct ClientTraceActivity : TraceActivity {`
`64`	`64`	`metadata_.push_back(std::move(kv));`
`65`	`65`	`}`
`66`	`66`
`67`		`- [[nodiscard]] const std::string getMetadata() const {`
	`67`	`+ const std::string getMetadata() const {`
`68`	`68`	`return fmt::format("{}", fmt::join(metadata_, ", "));`
`69`	`69`	`}`
`70`	`70`