Skip to content

Commit cfcd667

Browse files
fco-dvvfdev-5
andauthored
For v0.4.3 - Add more versionadded, versionchanged tags - Change v0.5… (#1612)
* For v0.4.3 - Add more versionadded, versionchanged tags - Change v0.5.0 to v0.4.3 * Update ignite/contrib/metrics/regression/canberra_metric.py Co-authored-by: vfdev <[email protected]> * Update ignite/contrib/metrics/regression/manhattan_distance.py Co-authored-by: vfdev <[email protected]> * Update ignite/contrib/metrics/regression/r2_score.py Co-authored-by: vfdev <[email protected]> * Update ignite/handlers/checkpoint.py Co-authored-by: vfdev <[email protected]> * address PR comments Co-authored-by: vfdev <[email protected]>
1 parent c25ce51 commit cfcd667

File tree

9 files changed

+26
-2
lines changed

9 files changed

+26
-2
lines changed

ignite/contrib/handlers/base_logger.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,9 @@ def attach_opt_params_handler(
207207
208208
Returns:
209209
:class:`~ignite.engine.RemovableEventHandle`, which can be used to remove the handler.
210+
211+
.. versionchanged:: 0.4.3
212+
Added missing return statement.
210213
"""
211214
return self.attach(engine, self._create_opt_params_handler(*args, **kwargs), event_name=event_name)
212215

ignite/contrib/metrics/regression/canberra_metric.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ class CanberraMetric(_BaseRegression):
2222
.. _scikit-learn distance metrics:
2323
https://scikit-learn.org/stable/modules/generated/sklearn.neighbors.DistanceMetric.html
2424
25+
.. versionchanged:: 0.4.3
26+
27+
- Fixed implementation: ``abs`` in denominator.
28+
- Works with DDP.
2529
"""
2630

2731
def __init__(

ignite/contrib/metrics/regression/manhattan_distance.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,10 @@ class ManhattanDistance(_BaseRegression):
2121
2222
__ https://scikit-learn.org/stable/modules/generated/sklearn.neighbors.DistanceMetric.html
2323
24+
.. versionchanged:: 0.4.3
25+
26+
- Fixed sklearn compatibility.
27+
- Workes with DDP.
2428
"""
2529

2630
def __init__(

ignite/contrib/metrics/regression/r2_score.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ class R2Score(_BaseRegression):
1919
2020
- ``update`` must receive output of the form ``(y_pred, y)`` or ``{'y_pred': y_pred, 'y': y}``.
2121
- `y` and `y_pred` must be of same shape `(N, )` or `(N, 1)` and of type `float32`.
22+
23+
.. versionchanged:: 0.4.3
24+
Works with DDP.
2225
"""
2326

2427
def __init__(

ignite/distributed/auto.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,9 @@ def auto_model(model: nn.Module, sync_bn: bool = False, **kwargs: Any) -> nn.Mod
174174
175175
- Added Horovod distributed framework.
176176
- Added ``sync_bn`` argument.
177+
178+
.. versionchanged:: 0.4.3
179+
Added kwargs to ``idist.auto_model``.
177180
"""
178181
logger = setup_logger(__name__ + ".auto_model")
179182

ignite/handlers/checkpoint.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,9 @@ def score_function(engine):
248248
> ["best_model_9_val_acc=0.77.pt", "best_model_10_val_acc=0.78.pt", ]
249249
250250
.. versionchanged:: 0.4.3
251-
Added ``greater_or_equal`` parameter.
251+
252+
- Checkpoint can save model with same filename.
253+
- Added ``greater_or_equal`` argument.
252254
"""
253255

254256
Item = NamedTuple("Item", [("priority", int), ("filename", str)])

ignite/metrics/metric.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,9 @@ def completed(self, engine: Engine, name: str) -> None:
302302
Args:
303303
engine (Engine): the engine to which the metric must be attached
304304
name (str): the name of the metric used as key in dict `engine.state.metrics`
305+
306+
.. versionchanged:: 0.4.3
307+
Added dict in metrics results.
305308
"""
306309
result = self.compute()
307310
if isinstance(result, Mapping):

ignite/metrics/psnr.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def get_y_channel(output):
6464
state = engine.run(data)
6565
print(f"PSNR: {state.metrics['psrn']}")
6666
67-
.. versionadded:: 0.5.0
67+
.. versionadded:: 0.4.3
6868
"""
6969

7070
def __init__(

ignite/utils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,8 @@ def manual_seed(seed: int) -> None:
156156
Args:
157157
seed (int): Random state seed
158158
159+
.. versionchanged:: 0.4.3
160+
Added ``torch.cuda.manual_seed_all(seed)``.
159161
"""
160162
random.seed(seed)
161163
torch.manual_seed(seed)

0 commit comments

Comments
 (0)