Make minor updates to LLM guide setup instructions #2940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/2940
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a4d75f4 with merge base 9fd1a0e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
GregoryComer
force-pushed
the
llm-doc-update-part-2
branch
from
663ccf5 to
a4d75f4
Compare
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
byjlw
approved these changes
Apr 9, 2024
Olivia-liu
pushed a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Apr 9, 2024
Summary: Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management. Pull Request resolved: pytorch#2940 Test Plan: Ran LLM guide prerequisite section on an m1 mac with pyenv-virtualenv. Differential Revision: D55913382 Pulled By: GregoryComer
Olivia-liu
pushed a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Apr 9, 2024
Summary: Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management. Pull Request resolved: pytorch#2940 Test Plan: Ran LLM guide prerequisite section on an m1 mac with pyenv-virtualenv. Differential Revision: D55913382 Pulled By: GregoryComer
Olivia-liu
pushed a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Apr 9, 2024
Summary: Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management. Pull Request resolved: pytorch#2940 Test Plan: Ran LLM guide prerequisite section on an m1 mac with pyenv-virtualenv. Differential Revision: D55913382 Pulled By: GregoryComer
Olivia-liu
pushed a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Apr 9, 2024
Summary: Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management. Pull Request resolved: pytorch#2940 Test Plan: Ran LLM guide prerequisite section on an m1 mac with pyenv-virtualenv. Differential Revision: D55913382 Pulled By: GregoryComer
Olivia-liu
pushed a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Apr 9, 2024
Summary: Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management. Pull Request resolved: pytorch#2940 Test Plan: Ran LLM guide prerequisite section on an m1 mac with pyenv-virtualenv. Differential Revision: D55913382 Pulled By: GregoryComer
Olivia-liu
pushed a commit
to Olivia-liu/executorch-1
that referenced
this pull request
Apr 9, 2024
Summary: Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management. Pull Request resolved: pytorch#2940 Test Plan: Ran LLM guide prerequisite section on an m1 mac with pyenv-virtualenv. Differential Revision: D55913382 Pulled By: GregoryComer
Olivia-liu
approved these changes
Apr 9, 2024
|
@GregoryComer merged this pull request in 218f643. |
|
@pytorchbot cherry-pick --onto release/0.2 -c docs |
pytorchbot
pushed a commit
that referenced
this pull request
Apr 10, 2024
Summary: Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management. Pull Request resolved: #2940 Test Plan: Ran LLM guide prerequisite section on an m1 mac with pyenv-virtualenv. Reviewed By: byjlw Differential Revision: D55913382 Pulled By: GregoryComer fbshipit-source-id: 7f04262b025db83b8621c972c90d3cdc3f029377 (cherry picked from commit 218f643)
Cherry picking #2940The cherry pick PR is at #2959 Details for Dev Infra teamRaised by workflow job |
guangy10
pushed a commit
that referenced
this pull request
Apr 10, 2024
Summary: Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management. Pull Request resolved: #2940 Test Plan: Ran LLM guide prerequisite section on an m1 mac with pyenv-virtualenv. Reviewed By: byjlw Differential Revision: D55913382 Pulled By: GregoryComer fbshipit-source-id: 7f04262b025db83b8621c972c90d3cdc3f029377 (cherry picked from commit 218f643) Co-authored-by: Gregory Comer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor updates to the prerequisite section of the LLM getting started guide. Passing -s to pyenv install prevents a prompt if python 3.10 is already installed (it will just silently continue in this case when the flag is passed). Additionally, under pyenv, we should be using python, not python3. I also added a little bit of wording on env management.