Arm backend: Fix bug in decompose linear vector norm #11755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The introduction of decomposition for linalg vector norm revealed a bug that when dim is None, then all dimensions should be reduced. Signed-off-by: Elena Zhelezina <[email protected]> Change-Id: Ic48e5c8304233052ed7ce7b7ee3fdee8c31a5d89
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11755
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 0ebf7fa with merge base b22a2be ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
wwwind
added
release notes: arm
zingo
added
the
partner: arm
zingo
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The introduction of decomposition for linalg vector norm revealed a bug that when dim is None, then all dimensions should be reduced.
Change-Id: Ic48e5c8304233052ed7ce7b7ee3fdee8c31a5d89
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218