Add numerical comparator base class and L1 comparator #11751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11751
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4080c87 with merge base be8ffd1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76746854 |
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
Summary: Pull Request resolved: pytorch#11751 This diff adds the numerical comparator base class and L1 comparator as the start of the numerical discrepancy analysis infrastructure. This setup provides a flexible framework for implementing various numerical comparison strategies by extending the NumericalComparatorBase class. The L1 comparator is a specific example that measures the sum of absolute differences between numerical inputs. Reviewed By: Gasoonjia Differential Revision: D76746854
|
This pull request was exported from Phabricator. Differential Revision: D76746854 |
Juntian777
force-pushed
the
export-D76746854
branch
from
c312c31 to
4080c87
Compare
Gasoonjia
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff adds the numerical comparator base class and L1 comparator as the start of the numerical discrepancy analysis infrastructure.
This setup provides a flexible framework for implementing various numerical comparison strategies by extending the NumericalComparatorBase class. The L1 comparator is a specific example that measures the sum of absolute differences between numerical inputs.
Reviewed By: Gasoonjia
Differential Revision: D76746854