Skip to content

Arm backend: Update Rescale and affected nodes to support TOSA 1.0 #10656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 2, 2025

Conversation

SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented May 2, 2025

Summary

Updates to rescale to support TOSA 1.0 specification and updates to nodevisitors affected.

Test plan

Tested through public and internal CI.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

SaoirseARM and others added 8 commits May 2, 2025 10:07
Change-Id: I066f59ad968f4a64ff77143fa76ea4a922997929
Signed-off-by: Saoirse Stewart <[email protected]>

Change-Id: I62e9040ee44ac953be1e7acbd3f8b325bb1f2294
Change-Id: Ifac3bc8af1059b48af69199dd149afd0180e4b94
…ates

Requires: view node visitor, rescale node visitor

Change-Id: Ie04f6dc20be22a8fa67d6527eb86bf82986236d9
- Updated abs, eq, ge, gt, le, lt, maximum (Nan attribute added),
minimum (Nan attribute added)

Signed-off-by: Saoirse Stewart <[email protected]>

Change-Id: Ib85d698c3b22ec9d8506d0ccb08e23966ec9e018
Signed-off-by: Saoirse Stewart <[email protected]>

Change-Id: I4f4122d297416c9a65f4011af8b357532cfeb26a
…OSA 1.0

Signed-off-by: Saoirse Stewart <[email protected]>

Change-Id: I15018fdf200888712f48ceab35b74b6799149e8d
Signed-off-by: Per Åstrand <[email protected]>
Change-Id: I88822c93470c4ff54f0e75df2f5ff271fa6bd1e6
Copy link

pytorch-bot bot commented May 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10656

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 079d756 with merge base d7030aa (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label May 2, 2025
@SaoirseARM
Copy link
Collaborator Author

@pytorchbot label "topic: not user facing"

@zingo
Copy link
Collaborator

zingo commented May 2, 2025

Android fails unrelated

@zingo zingo merged commit 3ca6cbb into pytorch:main May 2, 2025
173 of 174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants