Arm backend: Refactor TosaArg to use TosaSpecification #10655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor is_consumer_node_depthwise_conv2d to not use TosaArg. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I8a556ce290242b0a660f56a8f4048cba806817af
Refactor SliceCopySupport to not use TosaArg, but to use torch.fx.Node instead. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I1d67161d017a5e70348fa1aeaa0857041274bc6d
Refactor TosaArg to take TosaSpecification as an optional input. The spec is used for mapping torch.dtypes to to TOSA dtypes. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I2d52da4eededc36f8daefb3cb46214e9d374d306
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10655
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 78b9860 with merge base d7030aa ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make TosaArg aware of which TosaSpecification is used. This is used to map torch-dtypes to TOSA-dtypes.
cc @digantdesai @freddan80 @per @zingo