Skip to content

[ET-VK] Minor build graph change to improve model load time and memory. #10646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025

Conversation

trivedivivek
Copy link
Contributor

@trivedivivek trivedivivek commented May 2, 2025

A minor change in GraphBuilder to avoid creating a temp vector and reserve memory while building operator.

Differential Revision: [D73864959](https://our.internmc.facebook.com/intern/diff/D73864959/)

[ghstack-poisoned]
@trivedivivek trivedivivek requested a review from SS-JIA as a code owner May 2, 2025 00:55
Copy link

pytorch-bot bot commented May 2, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10646

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 1322e5e with merge base cd3b53d (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 2, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73864959

…e and memory."

A minor change in GraphBuilder to avoid creating a temp vector and reserve memory while building operator.

Differential Revision: [D73864959](https://our.internmc.facebook.com/intern/diff/D73864959/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73864959

…e and memory."

A minor change in GraphBuilder to avoid creating a temp vector and reserve memory while building operator.

Differential Revision: [D73864959](https://our.internmc.facebook.com/intern/diff/D73864959/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73864959

…e and memory."

A minor change in GraphBuilder to avoid creating a temp vector and reserve memory while building operator.

Differential Revision: [D73864959](https://our.internmc.facebook.com/intern/diff/D73864959/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73864959

@kirklandsign kirklandsign merged commit c03530e into gh/trivedivivek/80/base May 5, 2025
85 of 87 checks passed
@kirklandsign kirklandsign deleted the gh/trivedivivek/80/head branch May 5, 2025 20:23
@kirklandsign kirklandsign temporarily deployed to cherry-pick-bot May 5, 2025 20:23 — with GitHub Actions Inactive
kirklandsign pushed a commit that referenced this pull request May 5, 2025
…y. (#10688)

Pull Request resolved: #10646

A minor change in GraphBuilder to avoid creating a temp vector and reserve memory while building operator.
ghstack-source-id: 282013579
@exported-using-ghexport

Differential Revision: [D73864959](https://our.internmc.facebook.com/intern/diff/D73864959/)
phaiting pushed a commit that referenced this pull request May 6, 2025
…y. (#10688)

Pull Request resolved: #10646

A minor change in GraphBuilder to avoid creating a temp vector and reserve memory while building operator.
ghstack-source-id: 282013579
@exported-using-ghexport

Differential Revision: [D73864959](https://our.internmc.facebook.com/intern/diff/D73864959/)
jhelsby pushed a commit to jhelsby/executorch that referenced this pull request May 9, 2025
…y. (pytorch#10688)

Pull Request resolved: pytorch#10646

A minor change in GraphBuilder to avoid creating a temp vector and reserve memory while building operator.
ghstack-source-id: 282013579
@exported-using-ghexport

Differential Revision: [D73864959](https://our.internmc.facebook.com/intern/diff/D73864959/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants