Skip to content

[Feature Request] Add job_arn to benchmark result #10372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 23, 2025
Merged

[Feature Request] Add job_arn to benchmark result #10372

merged 3 commits into from
Apr 23, 2025

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Apr 22, 2025

Add device job_arn to track different device jobs.

Signed-off-by: Yang Wang <[email protected]>
Copy link

pytorch-bot bot commented Apr 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10372

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 22a6159 with merge base cfd1be3 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2025
Signed-off-by: Yang Wang <[email protected]>
@yangw-dev yangw-dev changed the title Add job_arn if any Add job_arn to benchmark result Apr 22, 2025
@yangw-dev yangw-dev requested a review from huydhn April 22, 2025 22:36
@yangw-dev yangw-dev marked this pull request as ready for review April 22, 2025 22:36
@huydhn
Copy link
Contributor

huydhn commented Apr 22, 2025

Please find lint before merging

@huydhn
Copy link
Contributor

huydhn commented Apr 22, 2025

Just FYI, I'm also adding the device pool name and id here so that I can differentiate between a S22 device from a public v.s. a S22 device from the private pool. Atm, I think they have the same name.

Signed-off-by: Yang Wang <[email protected]>
@yangw-dev
Copy link
Contributor Author

Just FYI, I'm also adding the device pool name and id here so that I can differentiate between a S22 device from a public v.s. a S22 device from the private pool. Atm, I think they have the same name.

sounds good!

@yangw-dev yangw-dev merged commit ad0f610 into main Apr 23, 2025
84 checks passed
@yangw-dev yangw-dev deleted the device-job branch April 23, 2025 19:44
SS-JIA added a commit that referenced this pull request Apr 23, 2025
* main:
  [ET-VK] Enable int8 tiled compute shader to be used with buffer tensors (#10415)
  Revert "Migrate elementwise_util callers to the variants with out_dtypes in template arguments" (#10411)
  Revert "Save some size in dtype_util when dtype selective build is not in use" (#10410)
  Generalize view_copy fusion.
  Add job_arn  to benchmark result (#10372)
  Revert "Minibench refactor (#10376)" (#10405)
  Revert "Arm backend: Populate __init__.py for quantizer and Arm root" (#10395)
  Arm backend: Convert assert to throw ValueError in op_log (#10392)
  Arm backend: Add Tutorial to Example tab on the Docs page (#10386)
  Arm backend: Update node visitors to support TOSA 1.0 (#10390)
  Arm backend: Make it easier to generate non delegated/quantized PTEs (#10387)
  Arm backend: Allow --quantize in non delegated using aot_arm_compiler (#10385)
  Arm backend: Set REGIONCFG registers of the Ethos-U (#10388)
@yangw-dev yangw-dev changed the title Add job_arn to benchmark result [Feature Request] Add job_arn to benchmark result May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants