Skip to content

Serialize PTD files with named data #10327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions exir/_serialize/_serialize.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,29 +102,34 @@ def serialize_for_executorch(
)

for tag in all_external_tags:
buffers = []
fqn_to_tensor_entry: Dict[str, TensorEntry] = {}
# pyre-ignore[16]: Undefined attribute: `Optional` has no attribute `get`.
fqn_to_index = emitter_output.external_constant_map.get(tag, {})
# Create a TensorEntry for each external tensor.
for fqn, index in fqn_to_index.items():
assert fqn in fqn_to_tensor_layout
fqn_to_tensor_entry[fqn] = TensorEntry(
buffer_index=index,
buffer_index=len(buffers),
layout=fqn_to_tensor_layout[fqn],
)
buffers.append(emitter_output.external_constant_buffer[index])

# Extract external data.
key_to_data: Dict[str, DataEntry] = {}
# pyre-ignore[16]: Undefined attribute: `Optional` has no attribute `get`.
key_to_buffer_index = named_data.external_data.get(tag, {})
for key, index in key_to_buffer_index.items():
# pyre-ignore[16]: Undefined attribute: `Optional` has no attribute `buffers`.
key_to_data[key] = DataEntry(index, named_data.buffers[index].alignment)
key_to_data[key] = DataEntry(
len(buffers), named_data.buffers[index].alignment
)
buffers.append(named_data.buffers[index].buffer)

# Serialize into PTD file.
ptd_files[tag] = data_serializer.serialize(
DataPayload(
buffers=emitter_output.external_constant_buffer,
buffers=buffers,
fqn_to_tensor=fqn_to_tensor_entry,
key_to_data=key_to_data,
)
Expand Down
Loading