Skip to content

Update size threshhold #10214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

Update size threshhold #10214

merged 1 commit into from
Apr 22, 2025

Conversation

JacobSzwejbka
Copy link
Contributor

Summary: These are the current actual threshholds

Differential Revision: D73056265

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Apr 15, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/10214

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 09168ab with merge base 85a8e88 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73056265

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 15, 2025
@JacobSzwejbka @facebook-github-bot
Update size threshhold (pytorch#10214)
ed13fb8 
Summary:

These are the current actual threshholds

Differential Revision: D73056265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73056265

@JacobSzwejbka
Copy link
Contributor Author

JacobSzwejbka commented Apr 15, 2025 •
edited
Loading

Do these numbers look like what you expect after your size work @swolchok ?

Im seeing a pretty huge regression from https://github.com/pytorch/executorch/actions/runs/14476679027/job/40603913130?pr=10144

and I have no idea why.

lucylq
lucylq approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@lucylq lucylq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating these!

@swolchok
Copy link
Contributor

Do these numbers look like what you expect after your size work @swolchok ?

no particular expectations.

Im seeing a pretty huge regression from https://github.com/pytorch/executorch/actions/runs/14476679027/job/40603913130?pr=10144

and I have no idea why.

I recommend using bloaty.

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 21, 2025
@JacobSzwejbka @facebook-github-bot
Update size threshhold (pytorch#10214)
0118335 
Summary:

These are the current actual threshholds

Reviewed By: lucylq

Differential Revision: D73056265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73056265

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 21, 2025
@JacobSzwejbka @facebook-github-bot
Update size threshhold (pytorch#10214)
3f32371 
Summary:
Pull Request resolved: pytorch#10214

These are the current actual threshholds

Reviewed By: lucylq

Differential Revision: D73056265
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 21, 2025
@JacobSzwejbka @facebook-github-bot
Update size threshhold (pytorch#10214)
9b32071 
Summary:

These are the current actual threshholds

Reviewed By: lucylq

Differential Revision: D73056265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73056265

JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Apr 21, 2025
@JacobSzwejbka @facebook-github-bot
Update size threshhold (pytorch#10214)
e1caf4a 
Summary:

These are the current actual threshholds

Reviewed By: lucylq

Differential Revision: D73056265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73056265

@JacobSzwejbka @facebook-github-bot
Update size threshhold (pytorch#10214)
09168ab 
Summary:

These are the current actual threshholds

Reviewed By: lucylq

Differential Revision: D73056265
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D73056265

@kirklandsign kirklandsign merged commit b52ad91 into pytorch:main Apr 22, 2025
83 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucylq lucylq lucylq approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JacobSzwejbka @facebook-github-bot @swolchok @lucylq @kirklandsign