Skip to content

Commit 6087d0f

Browse files
committed
Deprecate debug buffer in Module
Pull Request resolved: #14161 It's in release 0.7 so following deprecation schedule. debug_buffer is part of the event tracer, which is passed into Module. There isn't a public API on event tracer to set the debug_buffer, so the one held by Module is always empty. Added in D71135352 for pybindings migration, however the debug buffer is held by PyModule in that case. ghstack-source-id: 308829478 @exported-using-ghexport Differential Revision: [D82125911](https://our.internmc.facebook.com/intern/diff/D82125911/)
1 parent 0b78412 commit 6087d0f

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

extension/module/module.h

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -598,8 +598,9 @@ class Module {
598598
return event_tracer_.get();
599599
}
600600

601-
ET_NODISCARD
602-
runtime::Span<uint8_t> debug_buffer() {
601+
// Note: thie debug_buffer will always be empty. The one being used is in
602+
// the event_tracer attached to module. Please use that one.
603+
ET_DEPRECATED ET_NODISCARD runtime::Span<uint8_t> debug_buffer() {
603604
return runtime::Span<uint8_t>(debug_buffer_.data(), debug_buffer_.size());
604605
}
605606

@@ -622,7 +623,7 @@ class Module {
622623
std::unique_ptr<runtime::EventTracer> event_tracer_;
623624
std::unique_ptr<runtime::DataLoader> data_map_loader_;
624625
std::unique_ptr<NamedDataMap> data_map_;
625-
std::vector<uint8_t> debug_buffer_;
626+
ET_DEPRECATED std::vector<uint8_t> debug_buffer_;
626627

627628
protected:
628629
std::unordered_map<std::string, MethodHolder> methods_;

0 commit comments

Comments
 (0)