Skip to content

Commit 7a0371d

Browse files
Replacing the preprocessor conditions with if-elseif, as the
preprocessor code will never be compiled.
1 parent 71c527b commit 7a0371d

File tree

2 files changed

+8
-29
lines changed

2 files changed

+8
-29
lines changed

src/powerpc/linux/ppc64-hw.c

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,35 +1,17 @@
11
#include <string.h>
2-
32
#include <dlfcn.h>
43
#include <elf.h>
54
#include <errno.h>
65
#include <fcntl.h>
76
#include <sys/stat.h>
87
#include <sys/types.h>
98
#include <unistd.h>
10-
11-
#if CPUINFO_MOCK
12-
#include <cpuinfo-mock.h>
13-
#endif
14-
159
#include <cpuinfo.h>
1610
#include <cpuinfo/log.h>
1711
#include <powerpc/linux/api.h>
18-
1912
#include <sys/auxv.h>
2013

21-
#if CPUINFO_MOCK
22-
static uint32_t mock_hwcap = 0;
23-
void cpuinfo_set_hwcap(uint32_t hwcap) {
24-
mock_hwcap = hwcap;
25-
}
26-
#endif
27-
2814
void cpuinfo_powerpc_linux_hwcap_from_getauxval(uint32_t isa_feature[]) {
29-
#if CPUINFO_MOCK
30-
isa_feature[0] = mock_hwcap;
31-
#else
3215
isa_feature[0] = (uint32_t)getauxval(AT_HWCAP);
3316
isa_feature[1] = (uint32_t)getauxval(AT_HWCAP2);
34-
#endif
3517
}

test/name/power-features.cc

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,23 @@ TEST(PowerFeatures, Power) {
1616
fprintf(stderr, "failed to initialize CPU information\n");
1717
exit(1);
1818
}
19-
#if CPUINFO_MOCK
20-
int a = mock_hwcap;
21-
#else
22-
int a = (uint32_t)getauxval(AT_HWCAP);
23-
int b = (uint32_t)getauxval(AT_HWCAP2);
24-
#endif // CPUINFO_MOCK //
19+
uint32_t a = (uint32_t)getauxval(AT_HWCAP);
20+
volatile uint32_t b = (uint32_t)getauxval(AT_HWCAP2);
2521

26-
#if (b & CPUINFO_POWERPC_LINUX_FEATURE_ARCH_3_1)
22+
if (b & CPUINFO_POWERPC_LINUX_FEATURE_ARCH_3_1) {
2723
EXPECT_EQ(0, cpuinfo_has_powerpc_htm());
2824
EXPECT_EQ(1, cpuinfo_has_powerpc_mma());
2925
EXPECT_EQ(1, cpuinfo_has_powerpc_vsx());
30-
#elif (b & CPUINFO_POWERPC_LINUX_FEATURE_ARCH_3_00)
26+
}
27+
else if (b & CPUINFO_POWERPC_LINUX_FEATURE_ARCH_3_00) {
3128
EXPECT_EQ(0, cpuinfo_has_powerpc_htm());
3229
EXPECT_EQ(0, cpuinfo_has_powerpc_mma());
3330
EXPECT_EQ(1, cpuinfo_has_powerpc_vsx());
34-
#elif (b & CPUINFO_POWERPC_LINUX_FEATURE_ARCH_2_07)
31+
}
32+
else if (b & CPUINFO_POWERPC_LINUX_FEATURE_ARCH_2_07) {
3533
EXPECT_EQ(1, cpuinfo_has_powerpc_htm());
3634
EXPECT_EQ(0, cpuinfo_has_powerpc_mma());
3735
EXPECT_EQ(1, cpuinfo_has_powerpc_vsx());
38-
#endif
39-
36+
}
4037
cpuinfo_deinitialize();
4138
}

0 commit comments

Comments
 (0)