Skip to content

Use _GLIBCXX_USE_CXX11_ABI flag in conda builds, Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9, #1083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2022
Merged

Use _GLIBCXX_USE_CXX11_ABI flag in conda builds, Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9, #1083

merged 2 commits into from
Jul 12, 2022

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Jul 8, 2022 •
edited
Loading

This PR is fixing compatibility between gcc7 and gcc9 builds.

Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9

Note: This PR required following Pytorch PR: pytorch/pytorch#81058

@atalman atalman mentioned this pull request Jul 8, 2022
Closed
zou3519
zou3519 approved these changes Jul 8, 2022
View reviewed changes
Copy link
Contributor

@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably record somewhere that we can change the value of this flag if/when we stop compiling with gcc 7

@atalman atalman changed the title Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9 Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9, use _GLIBCXX_USE_CXX11_ABI flag in conda builds Jul 11, 2022
@atalman atalman changed the title Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9, use _GLIBCXX_USE_CXX11_ABI flag in conda builds Use _GLIBCXX_USE_CXX11_ABI flag in conda builds, Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9, Jul 11, 2022
@atalman atalman merged commit fb25f7e into pytorch:main Jul 12, 2022
pytorchmergebot pushed a commit to pytorch/pytorch that referenced this pull request Jul 12, 2022
@atalman @pytorchmergebot
Use fabi-version=11 to ensure compatibility between gcc7 and gcc9 bi…
d552ba3 
…naries (#81058)

Fixes: #80489

Test using cuda 11.3 manywheel binary:
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11_BUILD_ABI)
````

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
```

Functorch test torch : 1.13.0.dev20220707+cu113, functorch with cu102
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11_BUILD_ABI)
from functorch import vmap
x = torch.randn(2, 3, 5)
vmap(lambda x: x, out_dims=3)(x)
```

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
/home/atalman/temp/testc1.py:5: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:73.)
  x = torch.randn(2, 3, 5)
Traceback (most recent call last):
  File "/home/atalman/temp/testc1.py", line 6, in <module>
    vmap(lambda x: x, out_dims=3)(x)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 361, in wrapped
    return _flat_vmap(
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 488, in _flat_vmap
    return _unwrap_batched(batched_outputs, out_dims, vmap_level, batch_size, func)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 165, in _unwrap_batched
    flat_outputs = [
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 166, in <listcomp>
    _remove_batch_dim(batched_output, vmap_level, batch_size, out_dim)
IndexError: Dimension out of range (expected to be in range of [-3, 2], but got 3)
```

Related Builder  PR: pytorch/builder#1083

Test PR: #81232
Pull Request resolved: #81058
Approved by: https://github.com/zou3519, https://github.com/malfet
facebook-github-bot pushed a commit to pytorch/pytorch that referenced this pull request Jul 13, 2022
@atalman @facebook-github-bot
Use fabi-version=11 to ensure compatibility between gcc7 and gcc9 bin…
8a095c2 
…aries (#81058) (#81058)

Summary:
Fixes: #80489

Test using cuda 11.3 manywheel binary:
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11 (d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
````

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
```

Functorch test torch : 1.13.0.dev20220707+cu113, functorch with cu102
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11 (d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
from functorch import vmap
x = torch.randn(2, 3, 5)
vmap(lambda x: x, out_dims=3)(x)
```

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
/home/atalman/temp/testc1.py:5: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:73.)
  x = torch.randn(2, 3, 5)
Traceback (most recent call last):
  File "/home/atalman/temp/testc1.py", line 6, in <module>
    vmap(lambda x: x, out_dims=3)(x)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 361, in wrapped
    return _flat_vmap(
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 488, in _flat_vmap
    return _unwrap_batched(batched_outputs, out_dims, vmap_level, batch_size, func)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 165, in _unwrap_batched
    flat_outputs = [
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 166, in <listcomp>
    _remove_batch_dim(batched_output, vmap_level, batch_size, out_dim)
IndexError: Dimension out of range (expected to be in range of [-3, 2], but got 3)
```

Related Builder  PR: pytorch/builder#1083

Test PR: #81232

Pull Request resolved: #81058
Approved by: https://github.com/zou3519, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d552ba3b4f53da9b6a5f6e0463111e43b367ef8a

Reviewed By: DanilBaibak

Differential Revision: D37813240

Pulled By: atalman

fbshipit-source-id: 94d94e777b0e9d5da106173c06117b3019ba71c4
atalman added a commit to atalman/builder that referenced this pull request Jul 21, 2022
@atalman
Use _GLIBCXX_USE_CXX11_ABI flag in conda builds, Add _PYBIND11_BUILD_…
9675d79 
…ABI test for compatibility gcc7 vs gcc9, (pytorch#1083)

* Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9

* Using _GLIBCXX_USE_CXX11_ABI in Linux conda builds
@atalman atalman mentioned this pull request Jul 21, 2022
Merged
atalman added a commit that referenced this pull request Jul 21, 2022
@atalman
Use _GLIBCXX_USE_CXX11_ABI flag in conda builds, Add _PYBIND11_BUILD_…
1d9005c 
…ABI test for compatibility gcc7 vs gcc9, (#1083) (#1088)

* Add _PYBIND11_BUILD_ABI test for compatibility gcc7 vs gcc9

* Using _GLIBCXX_USE_CXX11_ABI in Linux conda builds
atalman added a commit to atalman/pytorch that referenced this pull request Jul 21, 2022
@atalman
Use fabi-version=11 to ensure compatibility between gcc7 and gcc9 bin…
dd558e4 
…aries (pytorch#81058) (pytorch#81058)

Summary:
Fixes: pytorch#80489

Test using cuda 11.3 manywheel binary:
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11 (pytorch@d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
````

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
```

Functorch test torch : 1.13.0.dev20220707+cu113, functorch with cu102
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11 (pytorch@d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
from functorch import vmap
x = torch.randn(2, 3, 5)
vmap(lambda x: x, out_dims=3)(x)
```

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
/home/atalman/temp/testc1.py:5: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:73.)
  x = torch.randn(2, 3, 5)
Traceback (most recent call last):
  File "/home/atalman/temp/testc1.py", line 6, in <module>
    vmap(lambda x: x, out_dims=3)(x)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 361, in wrapped
    return _flat_vmap(
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 488, in _flat_vmap
    return _unwrap_batched(batched_outputs, out_dims, vmap_level, batch_size, func)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 165, in _unwrap_batched
    flat_outputs = [
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 166, in <listcomp>
    _remove_batch_dim(batched_output, vmap_level, batch_size, out_dim)
IndexError: Dimension out of range (expected to be in range of [-3, 2], but got 3)
```

Related Builder  PR: pytorch/builder#1083

Test PR: pytorch#81232

Pull Request resolved: pytorch#81058
Approved by: https://github.com/zou3519, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d552ba3b4f53da9b6a5f6e0463111e43b367ef8a

Reviewed By: DanilBaibak

Differential Revision: D37813240

Pulled By: atalman

fbshipit-source-id: 94d94e777b0e9d5da106173c06117b3019ba71c4
@atalman atalman mentioned this pull request Jul 21, 2022
Merged
atalman added a commit to pytorch/pytorch that referenced this pull request Jul 21, 2022
@atalman
Use fabi-version=11 to ensure compatibility between gcc7 and gcc9 bin…
0e43325 
…aries (#81058) (#81058) (#81884)

Summary:
Fixes: #80489

Test using cuda 11.3 manywheel binary:
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11 (d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
````

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
```

Functorch test torch : 1.13.0.dev20220707+cu113, functorch with cu102
```
import torch
print(torch.__version__)
print(torch._C._PYBIND11 (d55b25a633b7e2e6122becf6dbdf0528df6e8b13)_BUILD_ABI)
from functorch import vmap
x = torch.randn(2, 3, 5)
vmap(lambda x: x, out_dims=3)(x)
```

Output
```
1.13.0.dev20220707+cu113
_cxxabi1011
/home/atalman/temp/testc1.py:5: UserWarning: Failed to initialize NumPy: No module named 'numpy' (Triggered internally at ../torch/csrc/utils/tensor_numpy.cpp:73.)
  x = torch.randn(2, 3, 5)
Traceback (most recent call last):
  File "/home/atalman/temp/testc1.py", line 6, in <module>
    vmap(lambda x: x, out_dims=3)(x)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 361, in wrapped
    return _flat_vmap(
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 488, in _flat_vmap
    return _unwrap_batched(batched_outputs, out_dims, vmap_level, batch_size, func)
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 165, in _unwrap_batched
    flat_outputs = [
  File "/home/atalman/conda/lib/python3.9/site-packages/functorch/_src/vmap.py", line 166, in <listcomp>
    _remove_batch_dim(batched_output, vmap_level, batch_size, out_dim)
IndexError: Dimension out of range (expected to be in range of [-3, 2], but got 3)
```

Related Builder  PR: pytorch/builder#1083

Test PR: #81232

Pull Request resolved: #81058
Approved by: https://github.com/zou3519, https://github.com/malfet

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d552ba3b4f53da9b6a5f6e0463111e43b367ef8a

Reviewed By: DanilBaibak

Differential Revision: D37813240

Pulled By: atalman

fbshipit-source-id: 94d94e777b0e9d5da106173c06117b3019ba71c4
@zhuhong61 zhuhong61 mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seemethere seemethere seemethere approved these changes

@malfet malfet malfet approved these changes

@zou3519 zou3519 zou3519 approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atalman @seemethere @malfet @zou3519 @facebook-github-bot