Add additional filter graph option to StreamWriter #3194
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mthrok has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 26, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: D44283910 Pulled By: mthrok fbshipit-source-id: 6da49264673b29a655a2fda3cd9a21b8e9baec18
|
This pull request was exported from Phabricator. Differential Revision: D44283910 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 26, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: D44283910 Pulled By: mthrok fbshipit-source-id: 85d04c4cbe92d82fdb5c6c8ff5316f162c9689aa
|
This pull request was exported from Phabricator. Differential Revision: D44283910 |
|
This pull request was exported from Phabricator. Differential Revision: D44283910 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 27, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: D44283910 Pulled By: mthrok fbshipit-source-id: d57688fcea3c839d4be41075b34480155e7fc65e
|
This pull request was exported from Phabricator. Differential Revision: D44283910 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 27, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: D44283910 Pulled By: mthrok fbshipit-source-id: 5e189df2808f14bba80dd3216cbe90e01331fc76
|
This pull request was exported from Phabricator. Differential Revision: D44283910 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 27, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: D44283910 Pulled By: mthrok fbshipit-source-id: 9f73bcabdeb01b88220d47809ef860e854878c85
Summary: StreamReader/Writer is evolving and the number of arguments in add_stream methods are growing. This commit adds default values to these arguments. Differential Revision: D44447263 fbshipit-source-id: 38371eb3359fc44b590d636657c651714dabcc71
Summary: Pull Request resolved: pytorch#3194 Differential Revision: D44283910 Pulled By: mthrok fbshipit-source-id: d5a9262c6a113f572e30c1c7c5b3bfc7bc68273f
|
This pull request was exported from Phabricator. Differential Revision: D44283910 |
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: https://www.internalfb.com/diff/D44283910?entry_point=27 Pulled By: mthrok fbshipit-source-id: 4ffb68bf01f8c7a05eba824efbafba8b30fcaff5
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: https://www.internalfb.com/diff/D44283910?entry_point=27 Pulled By: mthrok fbshipit-source-id: d550a454773850b4debcac7ed5d434efc2707c07
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: https://www.internalfb.com/diff/D44283910?entry_point=27 Pulled By: mthrok fbshipit-source-id: 81b30783578a8f57fdfe3cc25a91e92f27055c4a
mthrok
added a commit
to mthrok/audio
that referenced
this pull request
Mar 28, 2023
Summary: Pull Request resolved: pytorch#3194 Differential Revision: https://www.internalfb.com/diff/D44283910?entry_point=27 Pulled By: mthrok fbshipit-source-id: 81b30783578a8f57fdfe3cc25a91e92f27055c4a
|
Hey @mthrok. |
mthrok
changed the title
This was referenced Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for additional processing in StreamWriter with filter graph.