Fix slice and padding for TensorCoreTiledLayout #2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quantization Summary: Previously some of the code paths are not exercised, so the bug was not discovered but there are some bug related to slice operation and padding, basically scale and zero_point are not padded before, this results in errors when it is required. Test Plan: python test/dtypes/test_affine_quantized.py -k test_slice Reviewers: Subscribers: Tasks: Tags:
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2015
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bd34790 with merge base 0231a68 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
jerryzh168
force-pushed
the
fix-int4wo-slice
branch
from
9158d3c to
6c7671a
Compare
drisspg
reviewed
Apr 4, 2025
| @@ -297,14 +297,31 @@ def __torch_dispatch__(cls, func, types, args, kwargs): | |||
| if func is aten.slice.Tensor: | |||
There was a problem hiding this comment.
can we update this class to use the @dispatch pattern
There was a problem hiding this comment.
sure, can I do this in a separate PR?
drisspg
reviewed
Apr 4, 2025
| @@ -192,31 +192,26 @@ def __torch_dispatch__(cls, func, types, args, kwargs): | |||
|
|
|||
| if func is aten.slice.Tensor: | |||
| self, dim, start, end, step = fill_defaults(args, 5, [0, None, None, 1]) | |||
drisspg
reviewed
Apr 4, 2025
| @@ -335,31 +350,25 @@ def __torch_dispatch__(cls, func, types, args, kwargs): | |||
|
|
|||
| if func is aten.slice.Tensor: | |||
jerryzh168
changed the title
drisspg
approved these changes
Apr 5, 2025
jainapurva
pushed a commit
that referenced
this pull request
Apr 8, 2025
* Fix slice and padding for TensorCoreTiledLayout for int4 weight only quantization Summary: Previously some of the code paths are not exercised, so the bug was not discovered but there are some bug related to slice operation and padding, basically scale and zero_point are not padded before, this results in errors when it is required. Test Plan: python test/dtypes/test_affine_quantized.py -k test_slice Reviewers: Subscribers: Tasks: Tags: * skip if no cuda * update callsites for post_process * add back missing post process * adding missing arg for floatx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Previously some of the code paths are not exercised, so the bug was not discovered
but there are some bug related to slice operation and padding, basically scale and zero_point are not padded before, this results in errors when it is required.
Test Plan:
python test/dtypes/test_affine_quantized.py -k test_slice
Reviewers:
Subscribers:
Tasks:
Tags: