Apply lint to contributor PR on demand #1280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1280
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit fa0555a with merge base c546c5c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
msaroufim
added
the
topic: not user facing
drisspg
reviewed
Nov 13, 2024
.github/workflows/ruff_linter.yml
Outdated
| git config --global user.email 'github-actions[bot]@users.noreply.github.com' | ||
|
|
||
| # Apply fixes | ||
| ruff check --fix . |
There was a problem hiding this comment.
ruff check --select F,I --fix
I think we need this to match ci
drisspg
approved these changes
Nov 13, 2024
sunjiweiswift
pushed a commit
to sunjiweiswift/ao
that referenced
this pull request
Nov 25, 2024
* Apply lint to contributor PR on demand * Update ruff_linter.yml * Update ruff_linter.yml * Update ruff_linter.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my least favorite interactions with OSS users is asking them to lint their code, it causes huge delays in merging code for something that feels quite silly. See this PR as an example #1113
So instead when we feel like a contributor PR is close to getting merged, we can trigger a github action to push lint fixes to their branch directly
Main issue is this probably won't work for forks
And I got this working on my fork of ao https://github.com/msaroufim/ao
To test this I made a PR that ruins the lint on a specific file
You can see how the bot added changes to my PR
And this is how I trigger a lint job by passing in a link to the PR https://github.com/pytorch/ao/actions/workflows/ruff_linter.yml