Skip to content

Commit e5df48e

Browse files
authored
[test] Fix regression tests (#537)
* Fix regression tests Summary: Torch 2.2 is compiled with numpy 1.x, but when we `pip install -r requirements-dev.txt` we download a higher version of numpy (2.0) This causes an error with the .numpy() calls and importing torch in general. I don't think we want to pin the versions in requirements-dev.txt, so instead I added a pin to the numpy version in the specific torch spec, so it'll only run for 2.2. PT 2.3+ support numpy 2.0+ which is why those test don't fail. Test Plan: Reviewers: Subscribers: Tasks: Tags: * use == and specify for CPU as well * update
1 parent 5787e9e commit e5df48e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/regression_test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
include:
2424
- name: CUDA 2.2.2
2525
runs-on: linux.g5.12xlarge.nvidia.gpu
26-
torch-spec: 'torch==2.2.2'
26+
torch-spec: 'torch==2.2.2 "numpy<2" '
2727
gpu-arch-type: "cuda"
2828
gpu-arch-version: "12.1"
2929
- name: CUDA 2.3
@@ -38,7 +38,7 @@ jobs:
3838
gpu-arch-version: "12.1"
3939
- name: CPU 2.2.2
4040
runs-on: linux.4xlarge
41-
torch-spec: 'torch==2.2.2 --index-url https://download.pytorch.org/whl/cpu'
41+
torch-spec: 'torch==2.2.2 --index-url https://download.pytorch.org/whl/cpu "numpy<2" '
4242
gpu-arch-type: "cpu"
4343
gpu-arch-version: ""
4444
- name: CPU 2.3

0 commit comments

Comments
 (0)