Skip to content
This repository was archived by the owner on Sep 28, 2023. It is now read-only.

Support Image creation from byte buffer #32

Closed
wants to merge 1 commit into from

Conversation

brhcriteo
Copy link
Contributor

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @brhcriteo!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@willprice
Copy link
Contributor

Hi @brhcriteo,
This looks great. I'll try and review it and merge it this week.

@willprice willprice self-requested a review August 9, 2021 09:28
willprice added a commit that referenced this pull request Aug 13, 2021
* Support Image creation from byte buffer

* Compare reading from file vs. reading from buffer in test

* Add entry to changelog about reading from bytes

Co-authored-by: Bradley Howes <[email protected]>
@willprice
Copy link
Contributor

Great stuff @brhcriteo,
I've reviewed and made a few minor changes in #35 which is now merged. I'll cut a new release and deploy to conda forge shortly.

@willprice
Copy link
Contributor

Note this is now released as v0.2.0 on conda-forge. Happy image reading 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants