Skip to content

Updated API and prose in notebooks where necessary #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

tanayvarshney
Copy link
Contributor

Description

Updated notebooks for newer API and added some prose where necessary

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Updated existing assets
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/cpp/bin/torchtrtc/main.cpp b/tmp/changes.txt
index a437a5e..01452f1 100644
--- a/workspace/cpp/bin/torchtrtc/main.cpp
+++ b/tmp/changes.txt
@@ -460,7 +460,6 @@ int main(int argc, char** argv) {
    compile_settings.debug = true;
  }

-
  if (allow_gpu_fallback) {
    compile_settings.device.allow_gpu_fallback = true;
  }
@@ -583,7 +582,6 @@ int main(int argc, char** argv) {
    compile_settings.workspace_size = args::get(workspace_size);
  }

-
  if (truncate_long_and_double) {
    compile_settings.truncate_long_and_double = true;
  }
ERROR: Some files do not conform to style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some changes that do not conform to C++ style guidelines:

diff --git a/workspace/cpp/bin/torchtrtc/main.cpp b/tmp/changes.txt
index a437a5e..01452f1 100644
--- a/workspace/cpp/bin/torchtrtc/main.cpp
+++ b/tmp/changes.txt
@@ -460,7 +460,6 @@ int main(int argc, char** argv) {
    compile_settings.debug = true;
  }

-
  if (allow_gpu_fallback) {
    compile_settings.device.allow_gpu_fallback = true;
  }
@@ -583,7 +582,6 @@ int main(int argc, char** argv) {
    compile_settings.workspace_size = args::get(workspace_size);
  }

-
  if (truncate_long_and_double) {
    compile_settings.truncate_long_and_double = true;
  }
ERROR: Some files do not conform to style guidelines

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit 17490b1 into master Feb 14, 2022
@andi4191 andi4191 deleted the tvarshney_notebooks branch February 24, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants