-
Notifications
You must be signed in to change notification settings - Fork 364
Updated API and prose in notebooks where necessary #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: tvarshney <[email protected]>
4ad2031
to
fe046b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/cpp/bin/torchtrtc/main.cpp b/tmp/changes.txt
index a437a5e..01452f1 100644
--- a/workspace/cpp/bin/torchtrtc/main.cpp
+++ b/tmp/changes.txt
@@ -460,7 +460,6 @@ int main(int argc, char** argv) {
compile_settings.debug = true;
}
-
if (allow_gpu_fallback) {
compile_settings.device.allow_gpu_fallback = true;
}
@@ -583,7 +582,6 @@ int main(int argc, char** argv) {
compile_settings.workspace_size = args::get(workspace_size);
}
-
if (truncate_long_and_double) {
compile_settings.truncate_long_and_double = true;
}
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/cpp/bin/torchtrtc/main.cpp b/tmp/changes.txt
index a437a5e..01452f1 100644
--- a/workspace/cpp/bin/torchtrtc/main.cpp
+++ b/tmp/changes.txt
@@ -460,7 +460,6 @@ int main(int argc, char** argv) {
compile_settings.debug = true;
}
-
if (allow_gpu_fallback) {
compile_settings.device.allow_gpu_fallback = true;
}
@@ -583,7 +582,6 @@ int main(int argc, char** argv) {
compile_settings.workspace_size = args::get(workspace_size);
}
-
if (truncate_long_and_double) {
compile_settings.truncate_long_and_double = true;
}
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Updated notebooks for newer API and added some prose where necessary
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: