Update batchnorm to support 2D tensors (ie. BatchNorm1D) and add unit test case. #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoz-dev
force-pushed
the
chaoz/batch-norm1d
branch
from
4fc7f62 to
c76291f
Compare
Signed-off-by: Chao Zhang <[email protected]>
chaoz-dev
force-pushed
the
chaoz/batch-norm1d
branch
from
c76291f to
acddb41
Compare
chaoz-dev
changed the title
|
LGTM! Thanks! |
narendasan
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BatchNorm previously did not support 2D tensors, even though this is valid input (ie. BatchNorm1d). This change fixes this for the BatchNorm converter, as well as updating the unit tests to check against this.
Fixes # #692
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: