Skip to content

refactor: removing the strict_types and max_batch_size apis #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2022
Merged

refactor: removing the strict_types and max_batch_size apis #782

merged 1 commit into from
Feb 11, 2022

Conversation

peri044
Copy link
Collaborator

@peri044 peri044 commented Dec 21, 2021

BREAKING CHANGE: This commit removes the strict types and max_batch_size apis. We are doing this because the functionality of these APIs in TRT is convoluted and likely to be ignored during building. A replacement for strict types with actual guarantees will be added at a later date.

Signed-off-by: Dheeraj Peri [email protected]

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@peri044 peri044 requested a review from narendasan December 21, 2021 12:01
@github-actions github-actions bot added component: api [Python] Issues re: Python API component: api [C++] Issues re: C++ API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: tests Issues re: Tests documentation Improvements or additions to documentation labels Dec 21, 2021
@peri044
refactor: removing the strict_types and max_batch_size apis
b30cbd9 
BREAKING CHANGE: This commit removes the strict types and max_batch_size apis. We are doing this because the functionality of these APIs in TRT is convoluted and likely to be ignored during building. A replacement for strict types with actual guarantees will be added at a later date.

Signed-off-by: Dheeraj Peri <[email protected]>
github-actions[bot]
github-actions bot approved these changes Dec 21, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 21, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 21, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

github-actions[bot]
github-actions bot approved these changes Dec 21, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

@narendasan
Copy link
Collaborator

When are we updating to 8.2?

narendasan
narendasan approved these changes Feb 11, 2022
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narendasan narendasan merged commit c77def0 into master Feb 11, 2022
zsef123 added a commit to zsef123/TRTorch that referenced this pull request Feb 12, 2022
@zsef123
Fix build error from PR pytorch#782
61bf4a6
@zsef123 zsef123 mentioned this pull request Feb 12, 2022
Merged
6 tasks
zsef123 added a commit to zsef123/TRTorch that referenced this pull request Feb 12, 2022
@zsef123
Fix build error from PR pytorch#782
7dda059 
Signed-off-by: root <[email protected]>
zsef123 added a commit to zsef123/TRTorch that referenced this pull request Feb 16, 2022
@zsef123
Fix build error from PR pytorch#782
c4fb732 
Signed-off-by: root <[email protected]>
@peri044 peri044 deleted the trt8.2_update branch February 24, 2022 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
component: api [C++] Issues re: C++ API component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: tests Issues re: Tests documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peri044 @narendasan