-
Notifications
You must be signed in to change notification settings - Fork 365
refactor: Restructured python perf benchmark tool #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Anurag Dixit <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
Do you think we need the C++ benchmark as well?, maybe we have two subdirectories in //tools/perf one for the tool you wrote (we could call this benchmark or if you have an name you like) and the other one could be like cpp_bench or something |
@narendasan : This benchmark tool simply expects the .jit.pt or TRT engine file in the configuration to run perf tests. CPP benchmark example has a reference sample to generate and export a TS module. Hence, this tool simply refers to it for example. |
Yeah I mean we can change the role of the cpp_benchmark tool. The only reason we output an engine is to test with trtexec. It wasnt really intended to be an example other than to define a benchmarking procedure. |
Signed-off-by: andi4191 <[email protected]>
@narendasan : Can you take a look at this MR now? I have incorporated changes against the review comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to Python style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code conforms to C++ style guidelines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the training recipe being moved?
Training recipe is still inside the examples/ and not being moved to tools/ |
I mean its not really used for anything else from a user perspective |
This PR is tracked here: #879 Closing this PR |
Signed-off-by: Anurag Dixit [email protected]
Description
Re structured the python perf benchmark suite. Moved it to tools
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: