Skip to content

refactor: Restructured python perf benchmark tool #780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

andi4191
Copy link
Contributor

@andi4191 andi4191 commented Dec 21, 2021

Signed-off-by: Anurag Dixit [email protected]

Description

Re structured the python perf benchmark suite. Moved it to tools

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes

@andi4191 andi4191 requested a review from narendasan December 21, 2021 06:53
@andi4191 andi4191 self-assigned this Dec 21, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

@narendasan
Copy link
Collaborator

Do you think we need the C++ benchmark as well?, maybe we have two subdirectories in //tools/perf one for the tool you wrote (we could call this benchmark or if you have an name you like) and the other one could be like cpp_bench or something

@andi4191
Copy link
Contributor Author

@narendasan : This benchmark tool simply expects the .jit.pt or TRT engine file in the configuration to run perf tests. CPP benchmark example has a reference sample to generate and export a TS module. Hence, this tool simply refers to it for example.

@narendasan
Copy link
Collaborator

Yeah I mean we can change the role of the cpp_benchmark tool. The only reason we output an engine is to test with trtexec. It wasnt really intended to be an example other than to define a benchmarking procedure.

@andi4191
Copy link
Contributor Author

@narendasan : Can you take a look at this MR now? I have incorporated changes against the review comment.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to Python style guidelines

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code conforms to C++ style guidelines

Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the training recipe being moved?

@andi4191
Copy link
Contributor Author

Why is the training recipe being moved?

Training recipe is still inside the examples/ and not being moved to tools/
It was under int8. It is a simple training recipe. Why does it need to be in examples/int8?

@narendasan
Copy link
Collaborator

I mean its not really used for anything else from a user perspective

@andi4191
Copy link
Contributor Author

This PR is tracked here: #879

Closing this PR

@andi4191 andi4191 closed this Feb 17, 2022
@andi4191 andi4191 deleted the anuragd/pybenchmark_reorg branch February 24, 2022 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants