Ptq stabilization #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffered version to improve stability Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
interfere with TRTorch Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
benchmarking Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
Signed-off-by: Naren Dasan <[email protected]> Signed-off-by: Naren Dasan <[email protected]>
frank-wei
pushed a commit
that referenced
this pull request
Jun 4, 2022
Summary: Pull Request resolved: https://github.com/pytorch/fx2trt/pull/72 1. support value in pad op 2. permute op improvement since it could not handle x.permute(permutation) 3. improve setitem: 1) fix issue with slice(-n,None,None) 4. improve getitem: 1) support x[slice(None,None,None), slice(0,0,None)] This case is needed for setitem pass optimization. When we need to split a range where the dimension is (20,10) (slice(None,None,None), slice(-10,None,None)) --> (slice(None,None,None), slice(0,-10,None)) + (slice(None,None,None), slice(-10,None,None)) Reviewed By: yinghai Differential Revision: D36223023 fbshipit-source-id: 7d87c74b85b5c6c6efcd46dac209a46af208d3f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stabilizes the C++ calibrator implementation, using the dataloader alone caused non deterministic segfaults, so we now buffer calibration data in the calibrator
Also addresses a bug in the FP16 version of the benchmarking app where a workaround for batch norm in FP16 messed up compilation with the new batch norm implementation.
Now both ptq and benchmark also produce engine files for external testing (if
SAVE_ENGINE) is defined.Type of change
Please delete options that are not relevant and/or add your own.
Checklist:
make htmlin docsrc)