refactor! : Update default workspace size based on platforms. #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/core/conversion/conversionctx/ConversionCtx.cpp b/tmp/changes.txt
index 3c98207..62a2cfa 100644
--- a/workspace/core/conversion/conversionctx/ConversionCtx.cpp
+++ b/tmp/changes.txt
@@ -1,8 +1,8 @@
#include "core/conversion/conversionctx/ConversionCtx.h"
#include <cuda_runtime.h>
-#include <typeinfo>
#include <iostream>
#include <sstream>
+#include <typeinfo>
#include <utility>
namespace trtorch {
@@ -65,8 +65,8 @@ ConversionCtx::ConversionCtx(BuilderSettings build_settings)
cudaGetDeviceProperties(&device_prop, settings.device.gpu_id);
// GPU default WS size : 1 GB
// Jetson nano compute capability is 5.X. WS = 16 MB
- if (build_settings.workspace_size == 0){
- if (device_prop.major < 6){
+ if (build_settings.workspace_size == 0) {
+ if (device_prop.major < 6) {
settings.workspace_size = 256 * (1 << 20);
} else {
settings.workspace_size = 1 << 30;
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/core/conversion/conversionctx/ConversionCtx.cpp b/tmp/changes.txt
index 3c98207..62a2cfa 100644
--- a/workspace/core/conversion/conversionctx/ConversionCtx.cpp
+++ b/tmp/changes.txt
@@ -1,8 +1,8 @@
#include "core/conversion/conversionctx/ConversionCtx.h"
#include <cuda_runtime.h>
-#include <typeinfo>
#include <iostream>
#include <sstream>
+#include <typeinfo>
#include <utility>
namespace trtorch {
@@ -65,8 +65,8 @@ ConversionCtx::ConversionCtx(BuilderSettings build_settings)
cudaGetDeviceProperties(&device_prop, settings.device.gpu_id);
// GPU default WS size : 1 GB
// Jetson nano compute capability is 5.X. WS = 16 MB
- if (build_settings.workspace_size == 0){
- if (device_prop.major < 6){
+ if (build_settings.workspace_size == 0) {
+ if (device_prop.major < 6) {
settings.workspace_size = 256 * (1 << 20);
} else {
settings.workspace_size = 1 << 30;
ERROR: Some files do not conform to style guidelines
andi4191
approved these changes
Oct 18, 2021
| @@ -120,6 +135,7 @@ ConversionCtx::ConversionCtx(BuilderSettings build_settings) | |||
| cfg->setMinTimingIterations(settings.num_min_timing_iters); | |||
| cfg->setAvgTimingIterations(settings.num_avg_timing_iters); | |||
| cfg->setMaxWorkspaceSize(settings.workspace_size); | |||
|
|
|||
There was a problem hiding this comment.
@peri044 : Can we remove this?
| @@ -120,6 +135,7 @@ ConversionCtx::ConversionCtx(BuilderSettings build_settings) | |||
| cfg->setMinTimingIterations(settings.num_min_timing_iters); | |||
| cfg->setAvgTimingIterations(settings.num_avg_timing_iters); | |||
| cfg->setMaxWorkspaceSize(settings.workspace_size); | |||
|
|
|||
There was a problem hiding this comment.
@peri044 : Can we remove this? Is this for readability?
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/core/compiler.cpp b/tmp/changes.txt
index 0069598..69159f7 100644
--- a/workspace/core/compiler.cpp
+++ b/tmp/changes.txt
@@ -355,7 +355,7 @@ torch::jit::script::Module CompileGraph(const torch::jit::script::Module& mod, C
cudaDeviceProp device_prop;
cudaGetDeviceProperties(&device_prop, device_spec.gpu_id);
if (workspace_size == 0) {
- if (device_prop.major < 6){
+ if (device_prop.major < 6) {
cfg.convert_info.engine_settings.workspace_size = 256 * (1 << 20);
} else {
cfg.convert_info.engine_settings.workspace_size = 1 << 30;
diff --git a/workspace/core/conversion/conversionctx/ConversionCtx.cpp b/tmp/changes.txt
index 340724f..1dfd9fd 100644
--- a/workspace/core/conversion/conversionctx/ConversionCtx.cpp
+++ b/tmp/changes.txt
@@ -1,8 +1,8 @@
#include "core/conversion/conversionctx/ConversionCtx.h"
#include <cuda_runtime.h>
-#include <typeinfo>
#include <iostream>
#include <sstream>
+#include <typeinfo>
#include <utility>
namespace trtorch {
ERROR: Some files do not conform to style guidelines
There was a problem hiding this comment.
There are some changes that do not conform to C++ style guidelines:
diff --git a/workspace/core/compiler.cpp b/tmp/changes.txt
index dd4e716..f947e5c 100644
--- a/workspace/core/compiler.cpp
+++ b/tmp/changes.txt
@@ -355,7 +355,7 @@ torch::jit::script::Module CompileGraph(const torch::jit::script::Module& mod, C
cudaDeviceProp device_prop;
cudaGetDeviceProperties(&device_prop, device_spec.gpu_id);
if (workspace_size == 0) {
- if (device_prop.major < 6){
+ if (device_prop.major < 6) {
cfg.convert_info.engine_settings.workspace_size = 256 * (1 << 20);
} else {
cfg.convert_info.engine_settings.workspace_size = 1 << 30;
ERROR: Some files do not conform to style guidelines
peri044
force-pushed
the
ws_size
branch
2 times, most recently
from
03c0536 to
391a4c0
Compare
BREAKING CHANGE: This commit sets the default workspace size to 1GB for GPU platforms and 256MB for Jetson Nano/TX1 platforms whose compute capability is < 6. Signed-off-by: Dheeraj Peri <[email protected]> Signed-off-by: Dheeraj Peri <[email protected]> Signed-off-by: Dheeraj Peri <[email protected]> Signed-off-by: Dheeraj Peri <[email protected]> Signed-off-by: Dheeraj Peri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE: This commit sets the default workspace size to 1GB for GPU platforms and 256MB for Jetson Nano/TX1 platforms whose compute capability is < 6.
Type of change
Checklist: