Skip to content

fix: Fixing pybind error on nightly #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 13, 2022
Merged

fix: Fixing pybind error on nightly #1285

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7675a5
fix: Fixing pybind error on nightly
andi4191 Aug 18, 2022
1f30051
fix: pybind issue and handling exception
andi4191 Aug 18, 2022
0705a54
chore: pre-commit lint
andi4191 Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 51 additions & 9 deletions py/torch_tensorrt/csrc/torch_tensorrt_py.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,14 @@ class pyCalibratorTrampoline : public Derived {
using Derived::Derived; // Inherit constructors

int getBatchSize() const noexcept override {
PYBIND11_OVERLOAD_PURE_NAME(int, Derived, "get_batch_size", getBatchSize);
try {
PYBIND11_OVERLOAD_PURE_NAME(int, Derived, "get_batch_size", getBatchSize);
} catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_batch_size" + std::string(e.what()));
} catch (...) {
LOG_ERROR("Exception caught in get_batch_size");
}
return -1;
}

bool getBatch(void* bindings[], const char* names[], int nbBindings) noexcept override {
Expand Down Expand Up @@ -71,8 +78,15 @@ class pyIInt8Calibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Calibrato
using Derived::Derived;

nvinfer1::CalibrationAlgoType getAlgorithm() noexcept override {
PYBIND11_OVERLOAD_PURE_NAME(
nvinfer1::CalibrationAlgoType, nvinfer1::IInt8Calibrator, "get_algorithm", getAlgorithm);
try {
PYBIND11_OVERLOAD_PURE_NAME(
nvinfer1::CalibrationAlgoType, nvinfer1::IInt8Calibrator, "get_algorithm", getAlgorithm);
} catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_algorithm: " + std::string(e.what()));
} catch (...) {
LOG_ERROR("Exception caught in get_algorithm");
}
return {};
}
};

Expand All @@ -82,21 +96,49 @@ class pyIInt8LegacyCalibrator : public pyCalibratorTrampoline<nvinfer1::IInt8Leg
using Derived::Derived;

double getQuantile() const noexcept override {
PYBIND11_OVERLOAD_PURE_NAME(double, nvinfer1::IInt8LegacyCalibrator, "get_quantile", getQuantile);
try {
PYBIND11_OVERLOAD_PURE_NAME(double, nvinfer1::IInt8LegacyCalibrator, "get_quantile", getQuantile);
} catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_quantile: " + std::string(e.what()));
} catch (...) {
LOG_ERROR("Exception caught in get_quantile");
}
return -1.0;
}

double getRegressionCutoff() const noexcept override {
PYBIND11_OVERLOAD_PURE_NAME(double, nvinfer1::IInt8LegacyCalibrator, "get_regression_cutoff", getRegressionCutoff);
try {
PYBIND11_OVERLOAD_PURE_NAME(
double, nvinfer1::IInt8LegacyCalibrator, "get_regression_cutoff", getRegressionCutoff);
} catch (std::exception const& e) {
LOG_ERROR("Exception caught in get_regression_cutoff: " + std::string(e.what()));
} catch (...) {
LOG_ERROR("Exception caught in get_regression_cutoff");
}
return -1.0;
}

const void* readHistogramCache(std::size_t& length) noexcept override {
PYBIND11_OVERLOAD_PURE_NAME(
const void*, nvinfer1::IInt8LegacyCalibrator, "read_histogram_cache", readHistogramCache, length);
try {
PYBIND11_OVERLOAD_PURE_NAME(
const char*, nvinfer1::IInt8LegacyCalibrator, "read_histogram_cache", readHistogramCache, length);
} catch (std::exception const& e) {
LOG_ERROR("Exception caught in read_histogram_cache" + std::string(e.what()));
} catch (...) {
LOG_ERROR("Exception caught in read_histogram_cache");
}
return {};
}

void writeHistogramCache(const void* ptr, std::size_t length) noexcept override {
PYBIND11_OVERLOAD_PURE_NAME(
void, nvinfer1::IInt8LegacyCalibrator, "write_histogram_cache", writeHistogramCache, ptr, length);
try {
PYBIND11_OVERLOAD_PURE_NAME(
void, nvinfer1::IInt8LegacyCalibrator, "write_histogram_cache", writeHistogramCache, ptr, length);
} catch (std::exception const& e) {
LOG_ERROR("Exception caught in write_histogram_cache" + std::string(e.what()));
} catch (...) {
LOG_ERROR("Exception caught in write_histogram_cache");
}
}
};

Expand Down