fix: fix the renaming error in squeeze converter #1187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bo Wang <[email protected]>
github-actions
bot
added
component: conversion
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
peri044
reviewed
Jul 18, 2022
| @@ -26,7 +26,8 @@ auto squeeze_registrations TORCHTRT_UNUSED = RegisterNodeConversionPatterns().pa | |||
| } | |||
|
|
|||
| if (selfDim[dim] != 1) { | |||
| auto out = ctx->AssociateValueAndTensor(n->outputs()[0], self); | |||
| auto id_layer = ctx->net->addIdentity(*self); | |||
There was a problem hiding this comment.
You could use already existing utility for this
There was a problem hiding this comment.
thanks @peri044. BTW, do we still need this test case
? I'm thinking of deleting it.There was a problem hiding this comment.
Sounds good. This test doesn't seem useful.
There was a problem hiding this comment.
@peri044 it seems that we should have an explicit name for output tensor if we want to use this util:
.I checked around but have no idea what name would be appropriate, any idea?
narendasan
added
Story: Binding Names
|
@narendasan @bowang007 is it possible to get this into v1.2? Would be good to close out this issue in this release. |
Signed-off-by: Bo Wang <[email protected]>
narendasan
approved these changes
Jul 28, 2022
I don't think so. |
|
There are merge conflicts and these changes are already merged via another PR #1167 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bo Wang [email protected]
Description
Some converters may have the risks of renaming ITensors, which might cause errors.
Fixes: #930 , #982
More PRs related to this PR:
#1004 , #1167 ,
Type of change
Checklist: