-
Notifications
You must be signed in to change notification settings - Fork 258
Switch pipeline to Github Actions #866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
I have singed the CLA, waiting for the records to be updated :) |
Some of the pipeline issues are due to #865, but there are some others that are due to the python version not available in Github Actions. Versions not available are:
Some versions (like 3.4) can be fixed by specifying a sub version (ie 3.4.10 or 3.4.8), but I am unsure of the versions that you would need/like to have Available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json |
I think we can drop all sub versions, except for 3.4, where we should just use the latest version. |
bed71e3
to
4fe31e0
Compare
Removed the sub-versions and bumped up 3.4 to 3.4.10 |
- Changes requested - Split jobs into tests and linting
f84cb5f
to
90e966a
Compare
I'm not sure we can afford to drop the sub-versions; typing-extensions is tightly bound to the implementation of typing and unfortunately typing sometimes changes significantly between bugfix versions. |
Unfortunately we are bound to the constraints here. It might be possible to request the python versions in the setup-python repo Another option (but probably not recommended) would be to use the deadsnakes ppa to download the specific version of python we would need. But even the ppa doesnt have all python versions |
For now let's not worry about the micro versions then. |
Run "pytest", not "py.test"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Python 3.10 and linter failures are not related to this PR.
#868 for the linter warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert your last commit. See my comments above.
52aaedc
to
57a0660
Compare
Reverted 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR migrates the testing jobs from Travis CI to Github Actions
Also added python 3.10-dev to the CI
Closes #864