Skip to content

Split Best Practics document from Stubs document #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2022

Conversation

srittau
Copy link
Collaborator

@srittau srittau commented May 21, 2022

Move all "style guide" items over that apply to both stubs as well as
implementation. The items are reordered and the "Types" section was
split, but the text itself is unchanged.

Part of #851

Move all "style guide" items over that apply to both stubs as well as
implementation. The items are reordered and the "Types" section was
split, but the text itself is unchanged.

Part of python#851
@srittau
Copy link
Collaborator Author

srittau commented May 21, 2022

This is basically a first step towards #851 and gives a basis for adding more best practices. It also help to trim down the stubs document a bit.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@hauntsaninja hauntsaninja merged commit 831742f into python:master May 21, 2022
@srittau srittau deleted the best-practices branch May 21, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants