Allow nested tuples in isinstance/issubclass #998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilevkivskyi
reviewed
Mar 18, 2017
| @@ -718,8 +718,8 @@ def intern(string: str) -> str: ... | |||
| def iter(iterable: Iterable[_T]) -> Iterator[_T]: ... | |||
| @overload | |||
| def iter(function: Callable[[], _T], sentinel: _T) -> Iterator[_T]: ... | |||
| def isinstance(o: object, t: Union[type, Tuple[type, ...]]) -> bool: ... | |||
| def issubclass(cls: type, classinfo: Union[type, Tuple[type, ...]]) -> bool: ... | |||
| def isinstance(o: object, t: Union[type, Tuple[Union[type, Tuple], ...]]) -> bool: ... | |||
There was a problem hiding this comment.
@pkch @gvanrossum
I think here and below it should be Tuple[type, ...] no just Tuple at the end.
Otherwise isinstance(obj, ((1, 2), (3, 4)))will be valid.
This also applies to Python 3 stub.
There was a problem hiding this comment.
The problem is that the tuple can be arbitrarily nested. Excluding that example would also exclude isinstance(x, (((int, int), int), int)).
There was a problem hiding this comment.
OK, I still prefer the restrictive version a bit more, but this is not important. Anyway, there is no perfect solution until we support recursive types. (Btw, they are in my plans right after Protocols).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #997