Skip to content

Add typing-extensions to requirements-tests.txt #9438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jan 1, 2023

From the following comment: #9434 (comment)

I think typing_extensions is only available here because mypy depends on it, and we have mypy in our requirements-tests.txt file. We should probably add it to requirements-tests.txt, since implicit dependencies are generally a bad idea, and we also need the dependency for e.g. stubtest_stdlib.py. Want to make another PR adding it to requirements-tests.txt?

@Avasam Avasam changed the title Add typing-extensions to requirements Add typing-extensions to requirements-tests.txt Jan 1, 2023
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood merged commit c41fbc1 into python:main Jan 1, 2023
@Avasam Avasam deleted the add-typing-extensions-to-requirements branch February 29, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants