Skip to content

zipfile: improve bytes handling #9109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2022
Merged

zipfile: improve bytes handling #9109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea97014
zipfile: improve bytes handling
JelleZijlstra Nov 5, 2022
3f61bc7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions stdlib/zipfile.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import io
import sys
from _typeshed import Self, StrOrBytesPath, StrPath
from _typeshed import Self, StrOrBytesPath, StrPath, _BufferWithLen
from collections.abc import Callable, Iterable, Iterator
from os import PathLike
from types import TracebackType
Expand Down Expand Up @@ -103,7 +103,7 @@ class ZipFile:
compression: int # undocumented
compresslevel: int | None # undocumented
mode: _ZipFileMode # undocumented
pwd: str | None # undocumented
pwd: bytes | None # undocumented
if sys.version_info >= (3, 11):
@overload
def __init__(
Expand Down Expand Up @@ -173,7 +173,11 @@ class ZipFile:
self, filename: StrPath, arcname: StrPath | None = ..., compress_type: int | None = ..., compresslevel: int | None = ...
) -> None: ...
def writestr(
self, zinfo_or_arcname: str | ZipInfo, data: bytes | str, compress_type: int | None = ..., compresslevel: int | None = ...
self,
zinfo_or_arcname: str | ZipInfo,
data: _BufferWithLen | str,
compress_type: int | None = ...,
compresslevel: int | None = ...,
) -> None: ...
if sys.version_info >= (3, 11):
def mkdir(self, zinfo_or_directory_name: str | ZipInfo, mode: int = ...) -> None: ...
Expand Down