smtplib: Improve bytes handling #9094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexWaygood
reviewed
Nov 5, 2022
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
AlexWaygood
reviewed
Nov 5, 2022
AlexWaygood
reviewed
Nov 5, 2022
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
AlexWaygood
approved these changes
Nov 5, 2022
| def auth_plain(self, challenge: bytes | None = ...) -> str: ... | ||
| def auth_login(self, challenge: bytes | None = ...) -> str: ... | ||
| def auth_cram_md5(self, challenge: ReadableBuffer) -> str: ... | ||
| def auth_plain(self, challenge: ReadableBuffer | None = ...) -> str: ... |
There was a problem hiding this comment.
The challenge parameter doesn't look like it's actually used for this one
There was a problem hiding this comment.
The next one doesn't really use it either, I figured I should be consistent with auth_cram_md5.
There was a problem hiding this comment.
Yeah, that makes sense, I figured as much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.