Skip to content

Bump the rev of protobuf supported to 4.21.8 #8937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

nipunn1313
Copy link
Contributor

Bumping rev of mypy-protobuf incoming next

This change is fairly minor - just some comment changes in the generated stubs.

Bumping rev of mypy-protobuf incoming next
@github-actions

This comment has been minimized.

@AlexWaygood
Copy link
Member

We were wondering about removing google/__init__.pyi in our next major version bump for our protobuf stubs. Would you be interested in making that change as part of this PR? And if so -- would you be okay if we held off merging this until mypy 0.990 is released (should be in the next few weeks)? --namespace-packages will be the default in mypy 0.990, so it will make removing google/__init__.pyi much less painful for users (but we'd still rather make the change along with a major version bump, just to be sure).

@nipunn1313
Copy link
Contributor Author

Sure that works.

One idea could be to keep this at 3.21.8 until then - just to unblock/decouple this work from the __init__ work - since this piece is not actually a breaking change.

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit bcad078 into python:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants