-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Great cleanup! #8594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Great cleanup! #8594
Conversation
stdlib/xml/dom/minidom.pyi
Outdated
parentNode: Incomplete | ||
childNodes: Incomplete |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe also leave the ones that are explicitly marked as Incomplete
as they are? Since we've explicitly marked these as "we haven't figured out what they're meant to be yet", they might plausibly have different types in the subclass than in the superclass at runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to cancel all changes in this file :)
Because after my merge conflict I stopped understanding what is going on.
This comment has been minimized.
This comment has been minimized.
This error looks like a
Both types have pos-only parameters, but for some reason they are reported as incompatible. |
I believe it's actually stubtest working as intended; see python/mypy#13113. I can see both sides of the argument here :-) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't rigorously checked the whole thing to see if the signatures on subclasses are identical to the ones on superclasses, but I trust you to have done it properly :)
LGTM, though I'll wait to see if any other maintainers have any thoughts before merging.
I trust |
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Any other feedback? :) I think that this PR can quickly have merge conflicts and this will require some time to re-think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not checked this in depth, either, but the passing tests give me confidence.
I've searched for duplicate definitions and removed most of them.
This was a manual job with some help of a new
stubtest
.Rules:
__init__
)